Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add migrations for the policy-monitor sql schema #950

Conversation

ndr-brt
Copy link
Contributor

@ndr-brt ndr-brt commented Dec 20, 2023

WHAT

Adds schema migration for policy-monitor sql store

WHY

avoid exceptions when #947 will be fixed (by updating the upstream EDC dependencies version)

FURTHER NOTES

  • took the chance to do some (deserved) refactoring to the migration extensions hierarchy:
    • no need to have the DataSourceNameConfigurationKey and the SubsystemName defined separately as in the abstraction they were coupled anyway. I'm not sure why we permit the users to define a datasource name that's different from the subsystem name, it's only an internal key used to retrieve the datasource

Part of #947

@ndr-brt ndr-brt added enhancement New feature or request refactoring Refactoring, does not add functionality labels Dec 20, 2023
@ndr-brt ndr-brt force-pushed the 947-policy-monitor-store-migrations branch from 1236b84 to 8c48a17 Compare December 20, 2023 09:07
@ndr-brt ndr-brt force-pushed the 947-policy-monitor-store-migrations branch 6 times, most recently from 991721d to 5b178f4 Compare December 20, 2023 15:23
@ndr-brt ndr-brt force-pushed the 947-policy-monitor-store-migrations branch from 5b178f4 to d016a5d Compare December 20, 2023 15:27
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ndr-brt ndr-brt merged commit 481f66f into eclipse-tractusx:main Dec 21, 2023
26 checks passed
@ndr-brt ndr-brt deleted the 947-policy-monitor-store-migrations branch December 21, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Refactoring, does not add functionality
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants