feat: Add the folder path to the vault helm values

[AndrYurk]

WHAT

Add the vault.hashicorp.paths.folder to the helm chart

WHY

To allow specify the folder path, so all edc secrets could be stored directly in the data path.

Closes #1758

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[lgblaumeiser]

One question: Perhaps I miss something, but this change adds a configuration value to the helm charts, I miss the use of this configuration parameter somewhere. My understanding is, that the value has to be added to the construction of the access path to the vault in the connector, right? Does this already exist? Is this an upstream PR that is referenced?

[AndrYurk]

@lgblaumeiser, yes, we already have this in the connector
Upstream PR

Declaration:

@Setting(description = "The path of the folder that the secret is stored in, relative to VAULT_FOLDER_PATH", required = false, key = "edc.vault.hashicorp.folder")
private String folderPath;

https://github.com/eclipse-edc/Connector/blob/08f913e81b56ffa474783cf279cabe5fc0756a4b/extensions/common/vault/vault-hashicorp/src/main/java/org/eclipse/edc/vault/hashicorp/client/HashicorpVaultSettings.java#L54-L56

Usage:

var folderPath = settings.getFolderPath();

        var builder = baseUrl(settings)
                .newBuilder()
                .addPathSegments(PathUtil.trimLeadingOrEndingSlash(vaultApiPath))
                .addPathSegment(entryType);

        if (folderPath != null) {
            builder.addPathSegments(PathUtil.trimLeadingOrEndingSlash(folderPath));
        }

https://github.com/eclipse-edc/Connector/blob/08f913e81b56ffa474783cf279cabe5fc0756a4b/extensions/common/vault/vault-hashicorp/src/main/java/org/eclipse/edc/vault/hashicorp/client/HashicorpVaultClient.java#L280C13-L289

[lgblaumeiser]

lgtm