feat: add Token RefreshAPI to data plane #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
Feature
critical
paullatzelsperger
force-pushed
the
feat/1109_dataplane_token_refresh_api
branch
2 times, most recently
from
9116d0f to
54fff11
Compare
paullatzelsperger
changed the title
ndr-brt
approved these changes
Mar 12, 2024
edc-extensions/dataplane/dataplane-token-refresh/token-refresh-core/build.gradle.kts
Outdated
Show resolved
Hide resolved
paullatzelsperger
force-pushed
the
feat/1109_dataplane_token_refresh_api
branch
from
cbd530b to
1c5850f
Compare
wolf4ood
approved these changes
Mar 12, 2024
paullatzelsperger
force-pushed
the
feat/1109_dataplane_token_refresh_api
branch
2 times, most recently
from
71408db to
0bde1e3
Compare
paullatzelsperger
force-pushed
the
feat/1109_dataplane_token_refresh_api
branch
from
0bde1e3 to
8f0a249
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR adds the Refresh API to the dataplane, effectively exposing the possibility to refresh dataplane access tokens.
The Refresh API is registered into th
"public"context, thus it is available underPOST <HOST>:<PUBLIC_API_PORT>/<PUBLIC_API_PATH>/v1/token.Using all defaults, that is:
or - using the v2 endpoint:
using the V2 endpoint is highly encouraged as the V1 endpoint will not use data plane signaling, access tokens or token refresh!
WHY
Short-lived tokens are a security best-practice
FURTHER NOTES
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Closes # <-- insert Issue number if one exists