Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make statuslist type configureable #298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: make statuslist type configureable #298

wants to merge 1 commit into from

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Nov 12, 2024 •
edited
Loading

Description

The statuslist type used for the credentials is now configureable

Why

Since the currently used type for the status list (Statuslist2021) was hardcoded the type used in the credentials for the status list is now configureable to be able to use the BitstringStatusList

Issue

Refs: #299

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 requested a review from evegufy November 12, 2024 14:31
evegufy
evegufy requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helm install fails, could you please check?

As #224 contains a lot of different information, could you please create an own issue for that, similar to this one #226?

@evegufy evegufy added this to the Release 25.03 milestone Nov 12, 2024
@Phil91 Phil91 mentioned this pull request Nov 12, 2024
Open
13 tasks
@Phil91 Phil91 force-pushed the feature/224-statuslist branch from d001aaf to 8bdf822 Compare November 13, 2024 11:01
@Phil91 Phil91 requested a review from evegufy November 13, 2024 11:13
@Phil91 Phil91 force-pushed the feature/224-statuslist branch from 8bdf822 to cc757fc Compare November 13, 2024 11:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@evegufy evegufy added the merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled label Nov 13, 2024
@MaximilianHauer
Copy link
Contributor

@evegufy how do we proceed based on the last SSI EG meeting ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy Awaiting requested review from evegufy

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled
Projects
Portal
Status: IN PROGRESS
Milestone
Release 25.03
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @MaximilianHauer @evegufy