Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRIO-3 chore|fix: Debug the authentication and vault/persistence settings of the agent plane and upgrade version. #85

Merged
merged 16 commits into from
Nov 14, 2023
Merged

PRIO-3 chore|fix: Debug the authentication and vault/persistence settings of the agent plane and upgrade version. #85

merged 16 commits into from
Nov 14, 2023

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Oct 12, 2023 •
edited
Loading

WHAT

WHY

  • the current helm charts produced some problem in realistic deployment scenarios at ZF and ADAC.
  • github actions from non-github organizations could be hijacked.
  • erroneous tries to download artifacts from outdates repos pollute the build log
  • hardcoded versions in worfklows and poms should be easily manageable.

FURTHER NOTES

should wait for PR #86 to become green

this collides with the open PR #59 due to version numbers, but it integrates its changes.

Closes #81
Closes #58

@drcgjung
fix(auth-jwt): deprecate property names with hyphens since they colli…
6081c4f 
…de with environment variables. Introduce exclusion pattern.
@drcgjung
fix|chore: switch to additional authentication properties and default…
5fc1560 
…s in helm charts. upgrade versions. Remove cyclone SBOMs.
@drcgjung
fix(service-delegation): we do not have to check asset baseurls twice…
ac7fef6 
… for outgoing services, else each graph asset would need to list its baseUrls twice.
@drcgjung
feat: introduce EDC version information in the dataplane runtime.
17cce3d
@drcgjung drcgjung changed the title chore|fix: Debug the authentication and vault/persistence settings of the agent plane and upgrade version. PRIO-3 chore|fix: Debug the authentication and vault/persistence settings of the agent plane and upgrade version. Oct 16, 2023
@drcgjung
Copy link
Contributor Author

drcgjung commented Nov 9, 2023 •
edited
Loading

@carslen may I request your assistance / assign you to that PR please?

@drcgjung drcgjung mentioned this pull request Nov 9, 2023
Closed
@drcgjung drcgjung requested a review from carslen November 14, 2023 12:57
@carslen carslen merged commit 45c204d into eclipse-tractusx:main Nov 14, 2023
5 checks passed
@drcgjung drcgjung deleted the fix/81-authentication-improvements-and-chart branch April 17, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Martin0815bla Martin0815bla Martin0815bla approved these changes

@carslen carslen Awaiting requested review from carslen

Assignees
No one assigned
Labels
priority
Projects
Knowledge Agent Kanban Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm chart tractusx-dev/agent-connector-azure-vault v1.9.8 doesn't work Helm Chart is not usable standalone
3 participants
@drcgjung @carslen @Martin0815bla