Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix|chore: e2e test issues #229

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Jul 24, 2024

WHAT

  • Extend helm chart values with a "connector" section that was already implemented/foreseen in the templates.
  • Upgrade version.
  • Debug the "update skill" logic
  • Debug the Skill Provisioning Logic in AgentSource.

WHY

This makes it possible to configure the agent planes to run against "internally networked" connectors over http instead of https.
It resolves a bug in the CONSUMER mode of skills which would allow to run on PROVIDER and - else - misses to parameterize the query string in the presence of a resultset body.
It resolves a bug in the skill creation API which was expecting an id`d-response from an EDC management PUT request (which usually is empty).

FURTHER NOTES

Final release version is 1.13.22

Closes #228 <-- insert Issue number if one exists

@drcgjung drcgjung requested review from obalandi and almadigabor July 24, 2024 07:30
@drcgjung drcgjung added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jul 24, 2024
Copy link

@obalandi obalandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drcgjung drcgjung changed the title fix|chore: e2e test helm chart issues fix|chore: e2e test issues Jul 25, 2024
@almadigabor almadigabor merged commit 0d2d0be into eclipse-tractusx:main Jul 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

E2E test deployment issues
3 participants