Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend federated catalogue to allow for goal-oriented skills #183

Merged

Conversation

drcgjung
Copy link
Contributor

WHAT

This feature extends the federated catalogue and the associated synchronization process to store and reference about extended asset meta-data including shacl constraints to describe the graph shapes.

WHY

Using the extended catalogue triples makes it possible to implement goal-oriented skills which reason about the assets before negotiating/jumping into the actual data. The present implementation has been test-driven using two formerly separate skills from the Behaviour Twin Use case.

Furthermore the federated catalogue is now also aligned with the CX-0018 standard properties of assets.

FURTHER NOTES

Closes # <-- insert Issue number if one exists

@drcgjung
Copy link
Contributor Author

@almadigabor I will inform you once Oz and Martin have successfully reviewed the changes from the business and technical side. It would be nice if you could take that over, then.

Copy link
Contributor

@Martin0815bla Martin0815bla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes regarding formatting, constant introduction, allow/deny pattern, new methods and tests reviewd

@drcgjung drcgjung requested a review from Martin0815bla March 13, 2024 11:39
@drcgjung
Copy link
Contributor Author

Changes regarding formatting, constant introduction, allow/deny pattern, new methods and tests reviewd

@Martin0815bla sorry had to update some copyright periods as well.

Copy link
Contributor

@Martin0815bla Martin0815bla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes regarding formatting, constant introduction, allow/deny pattern, new methods, tests and copyright periods reviewed

Copy link

@obalandi obalandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine

@drcgjung
Copy link
Contributor Author

@almadigabor could you please take over, then? Thx!

@drcgjung drcgjung added the enhancement New feature or request label Mar 14, 2024
Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almadigabor almadigabor merged commit 3072a10 into eclipse-tractusx:main Mar 18, 2024
5 checks passed
@drcgjung drcgjung deleted the feature/73-goal-oriented-skills branch April 17, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants