Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Governance KIT Documentation #701

Merged
merged 81 commits into from
Mar 6, 2024
Merged

Conversation

dg-tsy
Copy link
Contributor

@dg-tsy dg-tsy commented Feb 20, 2024

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@maximilianong
Copy link
Contributor

Overall:

Sidebar navigation: link to KIT is missing
Please integrate swagger hub link in sidebar navigation
Example from certificate management KIT:
Bildschirmfoto 2024-02-26 um 19 54 35

Changelog:

Changelog version needs to be changed to 0.1.0
Change date to 08.03

Operation View:

Is this really needed?
Will there be a reference implementation provided in the future?

Suggestion:
Renaming from development view to archtictecture view - example from Traceability https://eclipse-tractusx.github.io/docs-kits/next/kits/Traceability%20Kit/Architecture%20View%20Traceability%20Kit

@dg-tsy
Copy link
Contributor Author

dg-tsy commented Feb 27, 2024

@maximilianong Here is the reply to your feedback comments:

  • sidebar navigation for Data Governance Kit added.
  • I could not find "Certificate Management Kit" anywhere. Could you please guide me to its correct path?
  • Changelog is now updated.
  • I thought that "Oparation View" was mandatory. When it's not mandatory, I can remove it in next iteration.
    There will be no reference implementation.
  • If I rename the development view to architecture view, then would I have an architecture view in addition to development view? If not, then where would the API specifications come? I propose to either keep it as it is or add two separate views architecture and development view. Please suggest.

I am still struggling about how to make "kits/Data Governance Kit/resources/openAPI.yaml" as a Tractus-X SwaggerHub API documentation. Any help in this regard is much appreciated.

@maximilianong
Copy link
Contributor

maximilianong commented Feb 28, 2024

Please fix the requested changes by 04.03.2024 (EOB) so that we can perform the final checks and prepare the release communication.

@dg-tsy we sent out the following explanation - please make sure you are on the Eclipse mailing list:

For APIs with reference implementation:

Please use (or adapt existing) automated workflows to publish on SwaggerHub. Maintain your openAPI.yaml and the publishing workflow in the repository of the reference implementation. Remove everything related to that from the website repo and only link to SwaggerHub in your KIT from now on.
We utilize a user provided by the Eclipse Foundation to publish on SwaggerHub.
Credentials for this user can be used through the eclipse-tractusx GitHub org secrets and can be utilized in automated workflows.
Pay special attention to the "swaggerHub" CLI commands.
The location where the openAPI file is maintained may vary. The BPDM example showcases how the application is initiated to download and publish the current file from that location.

  SWAGGERHUB_API_KEY: ${{ secrets.SWAGGERHUB_API_KEY }}
  SWAGGERHUB_USER: ${{ secrets.SWAGGERHUB_USER }}

Examples:
BPDM Certificate Management: [https://github.com/eclipse-tractusx/bpdm-certificate-management/blob/main/.github/workflows/publish-swagger-hub.yaml]

If you have any questions, please use the office hour:
https://eclipse-tractusx.github.io/community/open-meetings

@maximilianong
Copy link
Contributor

Operation view: not mandatory if you do not have something to operate :D please remove it with this PR.

Regarding your suggestion for development view - its ok to go with your approach.

@danielmiehle
Copy link
Contributor

@dg-tsy can you also fix your current linting issues, please?

image

@dg-tsy
Copy link
Contributor Author

dg-tsy commented Feb 29, 2024

@maximilianong Following tasks completed:

  • Operations View removed, also removed its references from /sidebarsDocsKits.js
  • Linting issues resolved
  • Added .mdx files for API details, hence changes suggested in this comment should not be required.

Please let me know if anything else is required. Looks like all changes done from my side.

@dg-tsy
Copy link
Contributor Author

dg-tsy commented Mar 5, 2024

@maximilianong
Could you please let me know if there are any open topics for me to work upon? Many thanks in advance.

@danielmiehle danielmiehle removed the request for review from maximilianong March 6, 2024 07:30
@maximilianong maximilianong merged commit 8e72979 into eclipse-tractusx:main Mar 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants