fix(rest): Add license information linking for project releases. #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkuma7
requested review from
heliocastro,
GMishx,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
GMishx
added
needs code review
needs general test
GMishx
requested changes
Jan 27, 2025
Comment on lines
1596
to
1598
| Set<String> mainLicenses = release.getMainLicenseIds() != null ? release.getMainLicenseIds() : new HashSet<>(); | ||
| Set<String> otherLicenses = release.getOtherLicenseIds() != null ? release.getOtherLicenseIds() | ||
| : new HashSet<>(); |
There was a problem hiding this comment.
In accordance with #2827, the main licenses and other licenses of the release should be overwritten.
Thus the mainLicenses and otherLicenses should always be created as fresh HashSet.
| jsonResult.put(SW360Constants.STATUS, SW360Constants.FAILURE); | ||
| } | ||
|
|
||
| componentClient.updateRelease(release, sw360User); |
There was a problem hiding this comment.
This call can result in creation of Moderation Request. Please add comment field for the same in the controller as done in #2405
| mediaType = "application/hal+json", | ||
| schema = @Schema(type = "object", implementation = JSONObject.class), | ||
| examples = @ExampleObject( | ||
| value = "{\n \"one\": [\"Release1\", \"Release2\"],\n \"mul\": [\"Release3\"]\n}" |
There was a problem hiding this comment.
The actual response seems more like following.
Suggested change
| value = "{\n \"one\": [\"Release1\", \"Release2\"],\n \"mul\": [\"Release3\"]\n}" | |
| value = "{\n \"releasesWithSingleCLI\": [\"Release1\", \"Release2\"],\n \"releasesWithMultipleCLI\": [\"Release3\"],\n \"STATUS\": \"FAILURE\"\n}" |
|
Any updates @nikkuma7 ? |
nikkuma7
force-pushed
the
feat/Add_License_Info_to_Release
branch
from
de1b3a4 to
42d0655
Compare
comment addressed. |
Signed-off-by: Nikesh kumar <[email protected]>
nikkuma7
force-pushed
the
feat/Add_License_Info_to_Release
branch
from
42d0655 to
fc1d47d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2844
Suggest Reviewer
How To Test?
resource/api/projects/{id}/addLinkedRelesesLicenses
please check project should have licenses attached.
Checklist
Must: