fix #16260

eclipse-sumo · Feb 27, 2025 · c8a9603 · c8a9603
1 parent 1418ec4
commit c8a9603
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 2 deletions.
diff --git a/src/guinetload/GUITriggerBuilder.cpp b/src/guinetload/GUITriggerBuilder.cpp
@@ -150,6 +150,7 @@ void
 GUITriggerBuilder::endStoppingPlace() {
     if (myCurrentStop != nullptr) {
         static_cast<GUINet*>(MSNet::getInstance())->registerRenderedObject(dynamic_cast<GUIGlObject*>(myCurrentStop));
+        myCurrentStop->finishedLoading();
         myCurrentStop = nullptr;
     } else {
         throw InvalidArgument("Could not end a stopping place that is not opened.");

diff --git a/src/guisim/GUIBusStop.cpp b/src/guisim/GUIBusStop.cpp
@@ -58,7 +58,9 @@ GUIBusStop::GUIBusStop(const std::string& id, SumoXMLTag element, const std::vec
                        double frompos, double topos, const std::string name, int personCapacity,
                        double parkingLength, const RGBColor& color) :
     MSStoppingPlace(id, element, lines, lane, frompos, topos, name, personCapacity, parkingLength, color),
-    GUIGlObject_AbstractAdd(GLO_BUS_STOP, id, GUIIconSubSys::getIcon(GUIIcon::BUSSTOP)) {
+    GUIGlObject_AbstractAdd(GLO_BUS_STOP, id, GUIIconSubSys::getIcon(GUIIcon::BUSSTOP)),
+    myEmptyColor(RGBColor::INVISIBLE)
+{
     // see MSVehicleControl defContainerType
     myWidth = MAX2(1.0, ceil((double)personCapacity / getTransportablesAbreast()) * myTransportableDepth);
     initShape(myFGShape, myFGShapeRotations, myFGShapeLengths, myFGSignPos, myFGSignRot);
@@ -102,6 +104,18 @@ GUIBusStop::initShape(PositionVector& fgShape,
 }
 
 
+void
+GUIBusStop::finishedLoading() {
+    if (hasParameter("emptyColor")) {
+        try {
+            myEmptyColor = RGBColor::parseColor(getParameter("emptyColor"));
+        } catch (ProcessError& e) {
+            WRITE_WARNINGF("Could not parse color '%' (%)", getParameter("emptyColor"), e.what());
+        }
+    }
+}
+
+
 bool
 GUIBusStop::addAccess(MSLane* const lane, const double startPos, const double endPos, double length, const MSStoppingPlace::AccessExit exit) {
     const bool added = MSStoppingPlace::addAccess(lane, startPos, endPos, length, exit);
@@ -185,6 +199,9 @@ GUIBusStop::drawGL(const GUIVisualizationSettings& s) const {
     if (getColor() != RGBColor::INVISIBLE) {
         color = getColor();
     }
+    if (myEmptyColor != RGBColor::INVISIBLE && myEndPositions.empty() && myWaitingTransportables.empty()) {
+        color = myEmptyColor;
+    }
     const bool s2 = s.secondaryShape;
     const Position& signPos = s2 ? myFGSignPos2 : myFGSignPos;
     // recognize full transparency and simply don't draw

diff --git a/src/guisim/GUIBusStop.h b/src/guisim/GUIBusStop.h
@@ -80,6 +80,7 @@ class GUIBusStop : public MSStoppingPlace, public GUIGlObject_AbstractAdd {
     /// @brief Destructor
     ~GUIBusStop();
 
+    void finishedLoading();
 
     /// @brief adds an access point to this stop
     bool addAccess(MSLane* const lane, const double startPos, const double endPos, double length, const MSStoppingPlace::AccessExit exit);
@@ -168,5 +169,5 @@ class GUIBusStop : public MSStoppingPlace, public GUIGlObject_AbstractAdd {
     /// @brief The coordinates of access points
     PositionVector myAccessCoords;
 
-
+    RGBColor myEmptyColor;
 };
diff --git a/src/microsim/MSStoppingPlace.h b/src/microsim/MSStoppingPlace.h
@@ -245,6 +245,9 @@ class MSStoppingPlace : public Named, public Parameterised {
     /// @brief get IDs of persons waiting at this stop
     void getWaitingPersonIDs(std::vector<std::string>& into) const;
 
+    /// @brief perform extra processing after element has been loaded
+    virtual void finishedLoading() {};
+
     /** @brief Remove all vehicles before quick-loading state */
     void clearState();
 

diff --git a/src/netload/NLTriggerBuilder.cpp b/src/netload/NLTriggerBuilder.cpp
@@ -869,6 +869,7 @@ NLTriggerBuilder::endParkingArea() {
 void
 NLTriggerBuilder::endStoppingPlace() {
     if (myCurrentStop != nullptr) {
+        myCurrentStop->finishedLoading();
         myCurrentStop = nullptr;
     } else {
         throw InvalidArgument("Could not end a stopping place that is not opened.");