GH-5254 LMDB store: Correctly clear common vocabulary cache. #5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenwenzel
force-pushed
the
GH-5254-clear-common-vocab-cache
branch
from
81e756e to
875bdaa
Compare
|
looks good from our side. Thanks @kenwenzel! was able to run GC 10M+ times for common and uncommon ns w/o incident. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #5254
Briefly describe the changes proposed in this PR:
Fixes exception by correctly clearing common vocabulary cache after garbage collecting unused IDs in value store.
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)