GH-5227: fix binding assigner optimizer in FedX #5228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmottestad
reviewed
Jan 21, 2025
| /** | ||
| * List of standard {@link QueryOptimizer}s applicable to federation | ||
| */ | ||
| protected static final List<QueryOptimizer> standardOptimizers = List.of( |
There was a problem hiding this comment.
Does this need to be protected?
There was a problem hiding this comment.
no need in this case, adjusted (as only change in the pushed commit). Thanks for the review
The federation optimizer was missing to execute the binding assigner (which injects external bindings into the statement pattern). The consequence was potentially incorrect results (due to source source selection with partial knowledge) as well as sub-optimal source selection Issue is covered with a unit test, which is failing in two places prior to this change.
aschwarte10
force-pushed
the
GH-5227-fedx-binding-assign-optimizer
branch
from
fa65202 to
99d7ba3
Compare
hmottestad
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #5227
The federation optimizer was missing to execute the binding assigner (which injects external bindings into the statement pattern). The consequence was potentially incorrect results (due to source source selection with partial knowledge) as well as sub-optimal source selection
Issue is covered with a unit test, which is failing in two places prior to this change.
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)