Apply theme color to status message in FindReplaceDialog #1500
Conversation
Test Results 902 files ±0 902 suites ±0 37m 55s ⏱️ + 2m 18s For more details on these failures, see this check. Results for commit efd5441. ± Comparison against base commit d005f97. ♻️ This comment has been updated with latest results. |
|
LGTM, thanks @HeikoKlare Heiko, you are our test master, so I assume you know how to handle the failing / removed tests. |
|
Yes, failing tests seem to be random failures as a result of regression tests added with #1132. I'm currently investigating the cause. |
HeikoKlare
force-pushed
the
findreplace-status-color
branch
2 times, most recently
from
630ccdd to
7cf11f0
Compare
The status shown in the FindReplaceDialog is currently written in red (on input error) or in black. When setting the black font color, it does not consider the theme style applied to the dialog. With this change, the status message color is properly set to the themed one used by the dialog.
HeikoKlare
force-pushed
the
findreplace-status-color
branch
from
7cf11f0 to
efd5441
Compare
|
@HeikoKlare just wanted to thank you for working on resolving this, as this bug has been present for many years :) |
|
Thanks for the pointer, @AObuchow! Then this should also solve the downstream theme issue 🙂 I have also verified that nothing breaks on Linux (on which theming the message has properly worked before, as also noted in AObuchow/Eclipse-Spectrum-Theme#36).
Test failures have been resolved and the remaining failure is an independent, random fail documented in #1183 |
The status shown in the
FindReplaceDialogis currently written in red (on input error) or in black. When setting the black font color, it does not consider the theme style applied to the dialog.With this change, the status message color is properly set to the themed one used by the dialog. When using light theme, nothing changes.
Before:
After:
Light theme:
