Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jenkinsfile to increase timeouts #919

Closed
wants to merge 1 commit into from

Conversation

iloveeclipse
Copy link
Member

Copy link
Contributor

Test Results

     299 files  ±0       299 suites  ±0   5m 42s ⏱️ -45s
  4 095 tests ±0    4 087 ✔️ ±0    8 💤 ±0  0 ±0 
12 197 runs  ±0  12 124 ✔️ ±0  73 💤 ±0  0 ±0 

Results for commit faa863e. ± Comparison against base commit 9e25e9e.

@iloveeclipse
Copy link
Member Author

@akurtakov : WDYT? Would avoid the issue we had with overcrouded jenkins.

@akurtakov
Copy link
Member

Let me start a new build forcing natives rebuild. IIRC it was less than an hour.

@akurtakov
Copy link
Member

@HannesWell I started a build with forceNative https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/master/308/parameters/ but it wasn't respected and detected as if natives rebuild is not needed. Would you please look into that?

@iloveeclipse
Copy link
Member Author

@akurtakov : the Jenkinsfile checks the last commit and if it is from HEAD commit author: [email protected] it will not build natives. So the build not doing anything is expected.

@akurtakov
Copy link
Member

@akurtakov : the Jenkinsfile checks the last commit and if it is from HEAD commit author: [email protected] it will not build natives. So the build not doing anything is expected.

But it shouldn't do that when forceNativeBuilds is passed.

@HannesWell
Copy link
Member

@akurtakov : the Jenkinsfile checks the last commit and if it is from HEAD commit author: [email protected] it will not build natives. So the build not doing anything is expected.

But it shouldn't do that when forceNativeBuilds is passed.

That's both right. This is a a not so nice work-around to prevent endless build loops and I would be more than happy if that could be handled more elegant (probably that has to be discussed with the infra team).
However I will fix the Jenkins-Pipeline tonight.
For now you can Replay the Pipeline from the Jenkins UI and un-comment the problematic check.

But what makes me wonder, shouldn't be the commit of this PR be the last one?

@akurtakov
Copy link
Member

In the rare cases when we hit such natives mismatch it would be nice if we can retrigger a full rebuild. Another case is if/when we update infrastructure (new Mac/Win/Linux builders with new native libraries.)

@iloveeclipse
Copy link
Member Author

Let me start a new build forcing natives rebuild. IIRC it was less than an hour.

I believe what we saw yesterday was caused by too many build jobs from many PR's running on Jenkins that caused such high overhead that the natives builds were timed out multiple times.

@basilevs
Copy link
Contributor

Are there any recommendations to PR authors given the situation? Should I retrigger failed builds somehow, or should I refrain to prevent overload?

@akurtakov
Copy link
Member

Are there any recommendations to PR authors given the situation? Should I retrigger failed builds somehow, or should I refrain to prevent overload?

I can give only generic one - use the resources with caution. E.g. I see 5 open PRs in swt repo from you . Are they all needed? I strongly recommend for related work to have 1 (2 at best) PRs so there is less pressure on builders.

With the above said - opening new stream is always tough period as everyone tries to push what he worked on during RCs freeze period combine that with releng changes and mass changes that are supposed to go in for M1 and infra has tough period . Usually after the first week things calm down.

@akurtakov
Copy link
Member

I'm closing this one, if the build didn't complete in 3h waiting one more is not helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants