-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jenkinsfile to increase timeouts #919
Conversation
@akurtakov : WDYT? Would avoid the issue we had with overcrouded jenkins. |
Let me start a new build forcing natives rebuild. IIRC it was less than an hour. |
@HannesWell I started a build with forceNative https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/master/308/parameters/ but it wasn't respected and detected as if natives rebuild is not needed. Would you please look into that? |
@akurtakov : the Jenkinsfile checks the last commit and if it is from |
But it shouldn't do that when forceNativeBuilds is passed. |
That's both right. This is a a not so nice work-around to prevent endless build loops and I would be more than happy if that could be handled more elegant (probably that has to be discussed with the infra team). But what makes me wonder, shouldn't be the commit of this PR be the last one? |
In the rare cases when we hit such natives mismatch it would be nice if we can retrigger a full rebuild. Another case is if/when we update infrastructure (new Mac/Win/Linux builders with new native libraries.) |
I believe what we saw yesterday was caused by too many build jobs from many PR's running on Jenkins that caused such high overhead that the natives builds were timed out multiple times. |
Are there any recommendations to PR authors given the situation? Should I retrigger failed builds somehow, or should I refrain to prevent overload? |
I can give only generic one - use the resources with caution. E.g. I see 5 open PRs in swt repo from you . Are they all needed? I strongly recommend for related work to have 1 (2 at best) PRs so there is less pressure on builders. With the above said - opening new stream is always tough period as everyone tries to push what he worked on during RCs freeze period combine that with releng changes and mass changes that are supposed to go in for M1 and infra has tough period . Usually after the first week things calm down. |
I'm closing this one, if the build didn't complete in 3h waiting one more is not helpful. |
See eclipse-platform/eclipse.platform.releng.aggregator#1608