[Build] Remove unnecessary processing of abandoned 'build.sha1' files #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They have not been updated for six years and are not considered anymore. This is probably because they are written in another location than where the 'build.sha1' committed into the fragments reside.
HannesWell
force-pushed
the
remove-unncessary-build.sha1-processing
branch
from
236ef3e to
9d02597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They have not been updated for six years and are not considered anymore. This is probably because they are written in another location than where the 'build.sha1' committed into the fragments reside.
But there is already an alternative mechanism used to check for changes, based on git tags.
In eclipse-platform/eclipse.platform.swt.binaries#57 the remaining
build.sha1files are removed from the binaries-repo.Part of #513