Using native zoom to compute size for width and height #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When autoScale is int200 the size compute for width and height is not scaled correctly during DPI change. Using native zoom instead of corrected zoom fixes the issue.
HeikoKlare
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Can you please explain why this is a reasonable fix?
If I am not mistaken, all size calculations/computations are currently based on scaling via the deviceZoom, not via the nativeZoom. So this change seems to introduce an inconsistency in how scaling of control sizes is performed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autoScale is int200 the size compute for width and height is not scaled for the following buttons correctly during DPI change. Using native zoom instead of corrected zoom fixes the issue.
Scenario
Moving from Secondary (200) to Primary (150) Project -> Properties -> Save actions. (autoScale = Int200)
Before Fix
After Fix
