Skip to content

Commit

Permalink
[Win32] Add missing releases of queried WebView interfaces
Browse files Browse the repository at this point in the history
For some recently added WebView interface retrievals, the according
release operations on disposal are missing. This change adds them.
  • Loading branch information
HeikoKlare committed Jan 28, 2025
1 parent 081eb9b commit 1b2ea28
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ ICoreWebView2 initializeWebView(ICoreWebView2Controller controller) {
webViewWrapper.webView_10 = initializeWebView_10(webView);
webViewWrapper.webView_11 = initializeWebView_11(webView);
webViewWrapper.webView_12 = initializeWebView_12(webView);
webViewWrapper.webView_13= initializeWebView_13(webView);
webViewWrapper.webView_13 = initializeWebView_13(webView);
webViewWrapperFuture.complete(webViewWrapper);
return webView;
}
Expand Down Expand Up @@ -744,8 +744,10 @@ void browserDispose(Event event) {
if (environment2 != null) environment2.Release();
if (settings != null) settings.Release();
if (webViewProvider.isWebView_2Available()) webViewProvider.getWebView_2(false).Release();
if (webViewProvider.isWebView_10Available()) webViewProvider.getWebView_10(false).Release();
if (webViewProvider.isWebView_11Available()) webViewProvider.getWebView_11(false).Release();
if (webViewProvider.isWebView_12Available()) webViewProvider.getWebView_12(false).Release();
if (webViewProvider.isWebView_13Available()) webViewProvider.getWebView_13(false).Release();
if(controller != null) {
// Bug in WebView2. Closing the controller from an event handler results
// in a crash. The fix is to delay the closure with asyncExec.
Expand Down

0 comments on commit 1b2ea28

Please sign in to comment.