Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing output specifications in build.properties #60

Closed

Conversation

HeikoKlare
Copy link
Contributor

No description provided.

@HeikoKlare HeikoKlare force-pushed the fix-build-properties branch 2 times, most recently from 998f030 to c8afb7f Compare November 22, 2023 17:15
@HeikoKlare HeikoKlare marked this pull request as ready for review November 22, 2023 17:30
@akurtakov akurtakov force-pushed the fix-build-properties branch 3 times, most recently from 14bb3b4 to bbae563 Compare November 30, 2023 14:09
@HeikoKlare HeikoKlare changed the title Remove obsolete source specifications in build.properties Add missing output specifications in build.properties Nov 30, 2023
@HannesWell HannesWell force-pushed the fix-build-properties branch from bbae563 to 0e19538 Compare January 2, 2024 22:16
@HannesWell
Copy link
Member

@HeikoKlare is this still relevant?
And although it is actually obvious that this is required, can you tell how you noticed this is missing?

@HannesWell HannesWell force-pushed the fix-build-properties branch from 0e19538 to dd0a69a Compare January 4, 2024 17:36
@HeikoKlare
Copy link
Contributor Author

I provided this PR together with PRs to all other Eclipse Platform repositories when we had an issue with the API baseline comparison in Tycho. If I remember correctly, the reason was that the baseline comparison uses the Eclipse compiler to generate the class files to compare, which output into the output folder according to the Eclipse project settings (i.e., as defined in the .classpath). The baseline comparison then uses what is specified as the output folder in the build.properties, which is why this usually has to be defined as bin. I systematically scanned and corrected all the build.properties files to have everything consistent, which is how I created this PR, even though there have not been any actual build problems with SWT binaries, as far as I remember.

With respect to the SWT binaries, I am not sure whether it is really relevant, as I think the compilation is done via ANT and no baseline comparison happens during the build. So probably we can simply drop this PR (or merge it for the sake of consistency to all other projects, even though it probably won't have any effect).

@HannesWell
Copy link
Member

Thanks for the elaboration and fixing all repos.

With respect to the SWT binaries, I am not sure whether it is really relevant, as I think the compilation is done via ANT and no baseline comparison happens during the build. So probably we can simply drop this PR (or merge it for the sake of consistency to all other projects, even though it probably won't have any effect).

In this case I also tend to say that we should just leave it as it is for now, especially since I (hopefully soon) will replace the ant compilation with a maven compilation of the Java files as part of eclipse-platform/eclipse.platform.swt#513 and also wanted to further unify the build of the fragments.

@HeikoKlare
Copy link
Contributor Author

In this case I also tend to say that we should just leave it as it is for now

Agreed. Thus closing this PR. Thanks for your work on simplifying the binaries/fragments build! Really looking forward to having the ANT build for the binaries replaced.

@HeikoKlare HeikoKlare closed this Jan 8, 2024
@HeikoKlare HeikoKlare deleted the fix-build-properties branch January 8, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants