Add detailed build instructions for OpenJDK8 #626
Conversation
buildenv/Build_Instructions_V8.md
Outdated
|
|
||
| 2. This build uses the same gcc and g++ compiler levels as OpenJDK, which might be | ||
| backlevel compared with the versions you use on your system. Create links for | ||
| the compilers with the following command: |
There was a problem hiding this comment.
Should be commands instead of command.
buildenv/Build_Instructions_V8.md
Outdated
| ln -s gcc-4.8 /usr/bin/gcc | ||
| ``` | ||
|
|
||
| 3. Download and setup **freemarker.jar** into a directory. The example commands use `/root` to be consistent with the Docker instructions. If you aren't using Docker, you probably want to store the freemarker.jar in your home directory. |
There was a problem hiding this comment.
Did you want to highlight the second occurrence of freemarker.jar, similarly to the jdk9 instructions?
buildenv/Build_Instructions_V8.md
Outdated
|
|
||
| A number of RPM packages are also required. The easiest method for installing these packages is to use `yum`, because `yum` takes care of any additional dependent packages for you. | ||
|
|
||
| Download the following file: [yum_install_aix-ppc64.txt](aix/jdk9/yum_install_aix-ppc64.txt) |
There was a problem hiding this comment.
Should be jdk8 instead of jdk9
| @@ -0,0 +1,50 @@ | |||
| # Copyright (c) 2017, 2017 IBM Corp. and others | |||
There was a problem hiding this comment.
I notice this file is the same as the jdk9 version (except for the V8 in the comment). Should we create a common directory like jdk8or9 to contain the common source and avoid having to update multiple files if something changes?
There was a problem hiding this comment.
Prefer to keep them separate as we do for docker files.
| Building OpenJDK Version 8 with OpenJ9 | ||
| ====================================== | ||
|
|
||
| Our website describes a simple [build process](http://www.eclipse.org/openj9/oj9_build.html) |
There was a problem hiding this comment.
This describes the Java 9 simple build process. Is there an equivalent page for java 8?
There was a problem hiding this comment.
It's the same page for both versions. There is a toggle to flip between instructions for 8 or 9.
|
@pshipton I've addressed all the changes you requested. |
Add markdown file for building OpenJDK8 with OpenJ9 on Linux and AIX systems. Add the yum text file that we reference in the AIX build instructions. Issue at github.com/eclipse-openj9/openj9-website/issues/25 [ci skip] Issue eclipse-openj9#25 Signed-off-by: Sue Chaplain <[email protected]>
| :ledger: | ||
|
|
||
| :construction: | ||
| We haven't created a full build process for Windows yet? Watch this space! |
There was a problem hiding this comment.
The v9 instructions could be updated similarly. I'll do both as an enhancement on a separate PR if that's ok?
|
lgtm Thanks @SueChaplain ! |
Add markdown file for building OpenJDK8 with
OpenJ9 on Linux and AIX systems.
Add the yum text file that we reference in the
AIX build instructions.
Issue at github.com/eclipse-openj9/openj9-website/issues/25
[ci skip]
Issue #25
Signed-off-by: Sue Chaplain [email protected]