Remove System.getSecurityManager calls from java.base and criu #20939
+60
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Theresa Mammarella <[email protected]>
JasonFengJ9
reviewed
Jan 16, 2025
| @@ -210,7 +210,9 @@ public static void runRunnableInNotCheckpointSafeMode(Runnable run) { | |||
|
|
|||
| @SuppressWarnings("restriction") | |||
| private static Unsafe unsafe; | |||
| /*[IF JAVA_SPEC_VERSION < 24]*/ | |||
There was a problem hiding this comment.
This file contains other security manager-related API usages, such as AccessController.doPrivileged(). Are they to be addressed in another PR?
There was a problem hiding this comment.
Yes I am planning to do those separately since there are also many uses.
Co-authored-by: Jason Feng <[email protected]>
theresa-m
force-pushed
the
securitymanager
branch
from
f1b55d8 to
fb0ffb9
Compare
JasonFengJ9
reviewed
Jan 17, 2025
| @@ -602,10 +613,12 @@ public InternalCRIUSupport setWorkDir(Path workDir) { | |||
| } | |||
| String dir = workDir.toAbsolutePath().toString(); | |||
|
|
|||
| /*[IF JAVA_SPEC_VERSION < 24]*/ | |||
There was a problem hiding this comment.
It seems
should be moved to this file and changed to
/*[IF (17 <= JAVA_SPEC_VERSION) & (JAVA_SPEC_VERSION < 24)]*/
@SuppressWarnings({ "deprecation", "removal" })
/*[ENDIF] (17 <= JAVA_SPEC_VERSION) & (JAVA_SPEC_VERSION < 24) */
because the deprecated System.getSecurityManager() usages are being removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove calls to System.getSecurityManager for JDK 24 since this method is deprecated for removal and returns null. This change also removes javadoc references to SecurityException which no longer apply with the removal of System.getSecurityManager.
I have more pull requests removing SecurityException and System.getSecurityManager coming. I wanted to break this into smaller chunks for review since there are many uses in OpenJ9.
Related: #20563