Print actual string arguments with -Xtrace (part 1) #20641

h3110n3rv3 · 2024-11-19T19:29:31Z

The changes reflect the feature request #16416.

Print the actual string instead of address at max of 32 characters.
Subsequent PRs: cmdline option for length (part 2) and tests (part 3).

Signed-off-by: Nick Kamal <[email protected]>

h3110n3rv3 · 2024-11-19T19:30:59Z

@TobiAjila could you please review for comments/concerns/feedback? Thanks

pshipton · 2024-11-19T20:58:27Z

@keithc-ca fyi the ras change.

runtime/rastrace/method_trace.c

tajila · 2024-11-21T13:18:58Z

In the commit message dont "Closes: #16416" since you will create another PR that adds the ability to toggle the length of the String, and another one for testing.

You can rename the title of the commit "Feature request: Print actual String arguments with Xtrace part 1", and then add a description to the commit message indicating what the future parts will be.

tajila · 2024-11-21T13:39:42Z

Please squash commits

tajila · 2024-11-21T13:40:03Z

@keithc-ca Please review these changes

… of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal <[email protected]>

… of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]>

keithc-ca

Please also update the commit message and the description here - the prefix "Feature request: " is not helpful.

The lines in the body of the commit message should be no longer than 72 characters each.

The "Signed-off-by:" line is missing <>; you want to write

Signed-off-by: Nick Kamal <[email protected]>

runtime/rastrace/method_trace.c

… following eclipse-openj9#20641 Adding cmdline option to specify string argument length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 1 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=invalid input" There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]>

tajila · 2024-11-26T13:15:47Z

@keithc-ca Please take another look at this

keithc-ca

Suggest the commit message should spell "string" consistently, include the hyphen in "-Xtrace" and use parentheses consistently when referring to "(part 1)", "(part 2)" or "(part 3)" (in lowercase).

runtime/rastrace/method_trace.c

The changes reflect the feature request eclipse-openj9#16416. Print the actual string instead of address at max of 32 characters. Subsequent PRs: cmdline option for length (part 2) and tests (part 3). Signed-off-by: Nick Kamal <[email protected]> Print actual string arguments with -Xtrace (part 1) The changes reflect the feature request eclipse-openj9#16416. Print the actual string instead of address at max of 32 characters. Subsequent PRs: cmdline option for length (part 2) and tests (part 3). Signed-off-by: Nick Kamal <[email protected]> Print actual String arguments with Xtrace part 1 The changes reflect the feature request eclipse-openj9#16416. Print the actual string instead of address at max of 32 characters. Subsequent PRs: cmdline option for length (Part 2) and tests (Part 3). Signed-off-by: Nick Kamal <[email protected]>

keithc-ca · 2024-11-27T20:48:17Z

Jenkins test sanity amac,win jdk21

keithc-ca · 2024-11-27T22:02:13Z

Aborting Windows build:

15:50:20  All nodes of label ‘ci.role.build&&hw.arch.x86&&sw.os.windows

keithc-ca

Tested locally.

The changes reflect the feature request eclipse-openj9#16416. Adding cmdline option to specify string argument length. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If methodStrArgLen = 0 or unspecified, default to 32. Other invalid inputs result in the input error. There will be subsequent PR for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> Print actual string arguments with -Xtrace (part 2) The changes reflect the feature request eclipse-openj9#16416. Adding cmdline option to specify string argument length. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If methodStrArgLen = 0 or unspecified, default to 32. Other invalid inputs result in the input error. There will be subsequent PR for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> Feature request: Print actual String arguments with Xtrace part 1 The changes reflect the feature request eclipse-openj9#16416. Instead of printing the memory address for string arguments, print the actual string at max of 32 characters. There will be subsequent PRs for cmdline option for string length (Part 2) and tests (Part 3). Signed-off-by: Nick Kamal [email protected] The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 following eclipse-openj9#20641 Adding cmdline option to specify string argument length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 1 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=invalid input" There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]>

… of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal <[email protected]>

… of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]>

… following eclipse-openj9#20641 Adding cmdline option to specify string argument length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 1 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=invalid input" There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]>

…- part 2 following eclipse-openj9#20641" This reverts commit 81ebf3b.

…- part 2 of eclipse-openj9#20641" This reverts commit 5fed7b4.

…- part 2 of eclipse-openj9#20641" This reverts commit 9d207fb.

…- part 2 of eclipse-openj9#20641" This reverts commit 1d2c828.

…- part 2 of eclipse-openj9#20641" This reverts commit 582d967.

…- part 2 of eclipse-openj9#20641" This reverts commit 148a6de.

… of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal <[email protected]>

… of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]>

… following eclipse-openj9#20641 Adding cmdline option to specify string argument length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 1 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=invalid input" There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]>

…- part 2 following eclipse-openj9#20641" This reverts commit 81ebf3b.

…- part 2 of eclipse-openj9#20641" This reverts commit 5fed7b4.

…- part 2 of eclipse-openj9#20641" This reverts commit 9d207fb.

…- part 2 of eclipse-openj9#20641" This reverts commit 1d2c828.

…- part 2 of eclipse-openj9#20641" This reverts commit 582d967.

…- part 2 of eclipse-openj9#20641" This reverts commit 148a6de.

The changes reflect the feature request eclipse-openj9#16416. Instead of printing the memory address for string arguments, print the actual string at max of 32 characters. There will be subsequent PRs for cmdline option for string length (Part 2) and tests (Part 3). Signed-off-by: Nick Kamal [email protected] The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> Print actual String arguments with Xtrace part 1 The changes reflect the feature request eclipse-openj9#16416. Print the actual string instead of address at max of 32 characters. Subsequent PRs: cmdline option for length (Part 2) and tests (Part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 following eclipse-openj9#20641 Adding cmdline option to specify string argument length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 1 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=invalid input" There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 3 Signed-off-by: Nick Kamal <[email protected]> cmdline tests for -Xtrace:methodstrarglen Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal <[email protected]> Update xtraceTests.xml Feature request: Print actual String arguments with Xtrace part 1 The changes reflect the feature request eclipse-openj9#16416. Instead of printing the memory address for string arguments, print the actual string at max of 32 characters. There will be subsequent PRs for cmdline option for string length (Part 2) and tests (Part 3). Signed-off-by: Nick Kamal [email protected] The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> Print actual String arguments with Xtrace part 1 The changes reflect the feature request eclipse-openj9#16416. Print the actual string instead of address at max of 32 characters. Subsequent PRs: cmdline option for length (Part 2) and tests (Part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 following eclipse-openj9#20641 Adding cmdline option to specify string argument length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 1 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=invalid input" There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 3 Signed-off-by: Nick Kamal <[email protected]> cmdline tests for -Xtrace:methodstrarglen Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal <[email protected]> Update xtraceTests.xml Revert "Update xtraceTests.xml" This reverts commit a02170c. Revert "cmdline tests for -Xtrace:methodstrarglen" This reverts commit f1a4e90. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 3" This reverts commit 44209db. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 following eclipse-openj9#20641" This reverts commit 81ebf3b. Revert "Print actual String arguments with Xtrace part 1" This reverts commit c5ca003. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641" This reverts commit 5fed7b4. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641" This reverts commit 9d207fb. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641" This reverts commit 1d2c828. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641" This reverts commit 582d967. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641" This reverts commit 148a6de. Revert "Feature request: Print actual String arguments with Xtrace part 1" This reverts commit 820e22e. Feature request: Print actual String arguments with Xtrace part 1 The changes reflect the feature request eclipse-openj9#16416. Instead of printing the memory address for string arguments, print the actual string at max of 32 characters. There will be subsequent PRs for cmdline option for string length (Part 2) and tests (Part 3). Signed-off-by: Nick Kamal [email protected] The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641 Adding cmdline option to specify string length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 0 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=<invalid input> " There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> Print actual String arguments with Xtrace part 1 The changes reflect the feature request eclipse-openj9#16416. Print the actual string instead of address at max of 32 characters. Subsequent PRs: cmdline option for length (Part 2) and tests (Part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 2 following eclipse-openj9#20641 Adding cmdline option to specify string argument length to be printed. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If no methodStrArgLen is specified, or is set to 0, the printed length is the default value of 32. Other invalid inputs result in the following: "Error processing trace option, detail: methodstrarglen takes an unsigned integer value from 1 to 128 Trace option unrecognized: -Xtrace:methodStrArgLen Error processing trace option: -Xtrace:methodStrArgLen=invalid input" There will be subsequent PRs for tests (part 3). Signed-off-by: Nick Kamal <[email protected]> The changes reflect the feature request eclipse-openj9#16416 - part 3 Signed-off-by: Nick Kamal <[email protected]> cmdline tests for -Xtrace:methodstrarglen Closes: eclipse-openj9#16416 Signed-off-by: Nick Kamal <[email protected]> Update xtraceTests.xml Revert "Update xtraceTests.xml" This reverts commit a02170c. Revert "cmdline tests for -Xtrace:methodstrarglen" This reverts commit f1a4e90. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 3" This reverts commit 44209db. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 following eclipse-openj9#20641" This reverts commit 81ebf3b. Revert "Print actual String arguments with Xtrace part 1" This reverts commit c5ca003. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641" This reverts commit 5fed7b4. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641" This reverts commit 9d207fb. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641" This reverts commit 1d2c828. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641" This reverts commit 582d967. Revert "The changes reflect the feature request eclipse-openj9#16416 - part 2 of eclipse-openj9#20641" This reverts commit 148a6de. Revert "Feature request: Print actual String arguments with Xtrace part 1" This reverts commit 820e22e.

tajila reviewed Nov 19, 2024

View reviewed changes

runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved

tajila reviewed Nov 19, 2024

View reviewed changes

runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved

h3110n3rv3 changed the title ~~WIP - Feature request: Print actual String arguments with Xtrace~~ Feature request: Print actual String arguments with Xtrace Nov 21, 2024

tajila reviewed Nov 21, 2024

View reviewed changes

runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved

tajila reviewed Nov 21, 2024

View reviewed changes

runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved

h3110n3rv3 changed the title ~~Feature request: Print actual String arguments with Xtrace~~ Feature request: Print actual String arguments with Xtrace part 1 Nov 21, 2024

tajila approved these changes Nov 21, 2024

View reviewed changes

tajila requested a review from keithc-ca November 21, 2024 13:40

h3110n3rv3 force-pushed the Feature-request-16416 branch from 343c787 to 2c11a5c Compare November 21, 2024 13:48

h3110n3rv3 mentioned this pull request Nov 21, 2024

Print actual string arguments with -Xtrace (part 2) #20662

Merged

keithc-ca requested changes Nov 21, 2024

View reviewed changes

h3110n3rv3 changed the title ~~Feature request: Print actual String arguments with Xtrace part 1~~ Print actual String arguments with Xtrace part 1 Nov 21, 2024

h3110n3rv3 force-pushed the Feature-request-16416 branch from 55aa497 to 4772a09 Compare November 21, 2024 20:04

keithc-ca requested changes Nov 26, 2024

View reviewed changes

runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved

runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved

runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved

h3110n3rv3 changed the title ~~Print actual String arguments with Xtrace part 1~~ Print actual string arguments with -Xtrace (part 1) Nov 27, 2024

h3110n3rv3 force-pushed the Feature-request-16416 branch from eea476f to 44a699a Compare November 27, 2024 16:09

keithc-ca reviewed Nov 27, 2024

View reviewed changes

runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved

keithc-ca approved these changes Nov 27, 2024

View reviewed changes

keithc-ca merged commit 4ee9b77 into eclipse-openj9:master Nov 27, 2024
5 of 7 checks passed

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this pull request Dec 17, 2024

Revert "The changes reflect the feature request eclipse-openj9#16416 …

8cc617c

…- part 2 following eclipse-openj9#20641" This reverts commit 81ebf3b.

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this pull request Dec 17, 2024

Revert "The changes reflect the feature request eclipse-openj9#16416 …

a1c9cb9

…- part 2 of eclipse-openj9#20641" This reverts commit 5fed7b4.

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this pull request Dec 17, 2024

Revert "The changes reflect the feature request eclipse-openj9#16416 …

0c34ad3

…- part 2 of eclipse-openj9#20641" This reverts commit 9d207fb.

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this pull request Dec 17, 2024

Revert "The changes reflect the feature request eclipse-openj9#16416 …

e4371c8

…- part 2 of eclipse-openj9#20641" This reverts commit 1d2c828.

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this pull request Dec 17, 2024

Revert "The changes reflect the feature request eclipse-openj9#16416 …

027b027

…- part 2 of eclipse-openj9#20641" This reverts commit 582d967.

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this pull request Dec 17, 2024

Revert "The changes reflect the feature request eclipse-openj9#16416 …

01d6258

…- part 2 of eclipse-openj9#20641" This reverts commit 148a6de.

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this pull request Dec 17, 2024

Revert "The changes reflect the feature request eclipse-openj9#16416 …

b81e09b

…- part 2 following eclipse-openj9#20641" This reverts commit 81ebf3b.

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this pull request Dec 17, 2024

Revert "The changes reflect the feature request eclipse-openj9#16416 …

f1fadee

…- part 2 of eclipse-openj9#20641" This reverts commit 5fed7b4.

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this pull request Dec 17, 2024

Revert "The changes reflect the feature request eclipse-openj9#16416 …

8fddf5a

…- part 2 of eclipse-openj9#20641" This reverts commit 9d207fb.

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this pull request Dec 17, 2024

Revert "The changes reflect the feature request eclipse-openj9#16416 …

69e1624

…- part 2 of eclipse-openj9#20641" This reverts commit 1d2c828.

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this pull request Dec 17, 2024

Revert "The changes reflect the feature request eclipse-openj9#16416 …

cb02324

…- part 2 of eclipse-openj9#20641" This reverts commit 582d967.

h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this pull request Dec 17, 2024

Revert "The changes reflect the feature request eclipse-openj9#16416 …

8986d11

…- part 2 of eclipse-openj9#20641" This reverts commit 148a6de.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Print actual string arguments with -Xtrace (part 1) #20641

Print actual string arguments with -Xtrace (part 1) #20641

h3110n3rv3 commented Nov 19, 2024 •

edited

Loading

h3110n3rv3 commented Nov 19, 2024

pshipton commented Nov 19, 2024

tajila commented Nov 21, 2024

tajila commented Nov 21, 2024

tajila commented Nov 21, 2024

keithc-ca left a comment

tajila commented Nov 26, 2024

keithc-ca left a comment

keithc-ca commented Nov 27, 2024

keithc-ca commented Nov 27, 2024

keithc-ca left a comment

Print actual string arguments with -Xtrace (part 1) #20641

Print actual string arguments with -Xtrace (part 1) #20641

Conversation

h3110n3rv3 commented Nov 19, 2024 • edited Loading

h3110n3rv3 commented Nov 19, 2024

pshipton commented Nov 19, 2024

tajila commented Nov 21, 2024

tajila commented Nov 21, 2024

tajila commented Nov 21, 2024

keithc-ca left a comment

Choose a reason for hiding this comment

tajila commented Nov 26, 2024

keithc-ca left a comment

Choose a reason for hiding this comment

keithc-ca commented Nov 27, 2024

keithc-ca commented Nov 27, 2024

keithc-ca left a comment

Choose a reason for hiding this comment

h3110n3rv3 commented Nov 19, 2024 •

edited

Loading