Fix missing condition for scrubbing reference of unamedModuleObject #14577
Conversation
|
Let's also update a couple of similar spots in CopyForwardScheme with success flag. It might not be a correctness problem, but at least we want the code to be consistent. |
A card can be scrubbed only if no inter-region reference coming out of it exists. Signed-off-by: Lin Hu <[email protected]>
LinHu2016
force-pushed
the
issue14396
branch
from
202760f to
e846660
Compare
|
Jenkins test sanity xLinux jdk11 |
|
I expect PR testing should include the suite which fails in #14396, which is the extended.functional ( |
|
We are doing separate grinders to prove this is indeed fixing the problem, so I just launched a basic sanity test here. But feel free to launch more extended tests. |
|
Sounds good, I know it's intermittent. If there is still a problem after merging this I expect it will show up in the nightly builds after a while, I won't run any additional PR testing if testing is being done via grinders. |
|
@LinHu2016 Pls create a PR against the 0.31 branch. |
|
@pshipton @LinHu2016 please note we need PR against 0.31 branch for #14471 too |
|
Thanks. Both commits can be cherry picked to the same PR if you prefer. |
A card can be scrubbed only if no inter-region reference coming out of
it exists.
fix: #14396
Signed-off-by: Lin Hu [email protected]