Remove signatures from wrapped source bundles #1925
Merged
+112
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when the source bundle is signed, wrapping it into a source bundle will break the signature and make the jar invalid. This now removes the signature from source bundles as they are transformed.
Test Results 321 files ±0 321 suites ±0 50m 48s ⏱️ - 2m 26s For more details on these failures and errors, see this check. Results for commit 24edc59. ± Comparison against base commit c464287. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the source bundle is signed, wrapping it into a source bundle will break the signature and make the jar invalid.
This now removes the signature from source bundles as they are transformed.
See eclipse-tycho/tycho#4702