Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CLI ca-file requirement for sandbox connections. #3592

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

calohmn
Copy link
Contributor

@calohmn calohmn commented Dec 3, 2023

Follow-up of #3570:
The CLI --ca-file parameter shouldn't be required when connecting to the sandbox.

@sophokles73
Copy link
Contributor

sophokles73 commented Dec 4, 2023

GraalVM 21 copies the JDK's cacerts into the executable at build time. Thus, if the root CAs expire or get revoked etc, it will still be necessary to specify the trusted certs store on the command line. Anyway, for the JRE based version, this will most likely work as expected and for the native executable the --ca-file parameter can still be used.
@calohmn Maybe you could add some corresponding wording to the documentation?

@calohmn calohmn force-pushed the PR/cli_sandbox_no_cafile_param branch from a9fbf4b to 961ffd1 Compare December 14, 2023 07:38
@calohmn
Copy link
Contributor Author

calohmn commented Dec 14, 2023

@sophokles73 I've added a corresponding note in the "Getting Started" guide.

Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calohmn calohmn added this to the 2.5.0 milestone Dec 15, 2023
@calohmn calohmn merged commit b025a36 into eclipse-hono:master Dec 15, 2023
7 checks passed
@calohmn calohmn deleted the PR/cli_sandbox_no_cafile_param branch December 15, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants