Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2029] Use Command Router in adapters and integration tests #2312

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

calohmn
Copy link
Contributor

@calohmn calohmn commented Nov 20, 2020

This is for #2029.

This adds a org.eclipse.hono.adapter.client.command.CommandConsumerFactory implementation that uses the new Command Router component.
For the integration tests, a new maven profile command-router is added to let the tests run using the Command Router component.
The GitHub action workflow has been adapted to use that profile in the test-run that uses the jdbc device registry (so that the other test-runs still use the old command routing mechanism).

@calohmn calohmn added enhancement C&C Command and Control labels Nov 20, 2020
@calohmn calohmn added this to the 1.5.0 milestone Nov 20, 2020
@calohmn calohmn force-pushed the PR/use_cmdrouter_in_adapters branch 6 times, most recently from fb6b499 to aa5f662 Compare November 23, 2020 07:50
@calohmn calohmn force-pushed the PR/use_cmdrouter_in_adapters branch 3 times, most recently from 79a6413 to 4f31d38 Compare November 23, 2020 17:20
…sts.

This adds a org.eclipse.hono.adapter.client.command.CommandConsumerFactory
implementation that uses the new Command Router component.
For the integration tests, a new maven profile 'command-router' is added to
let the tests run using the Command Router component.
The GitHub action workflow has been adapted to use that profile in the
test-run that uses the jdbc device registry (so that the other test-runs
still use the old command routing mechanism).

Signed-off-by: Carsten Lohmann <[email protected]>
@calohmn calohmn force-pushed the PR/use_cmdrouter_in_adapters branch from 4f31d38 to 4a7863d Compare November 26, 2020 08:52
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calohmn calohmn merged commit 4533442 into eclipse-hono:master Nov 26, 2020
@calohmn calohmn deleted the PR/use_cmdrouter_in_adapters branch November 26, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C&C Command and Control enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants