Use void future in client removeCommandHandlingAdapterInstance() #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calohmn
added
the
Device Connection
sophokles73
reviewed
Oct 20, 2020
.../org/eclipse/hono/deviceconnection/infinispan/client/CacheBasedDeviceConnectionInfoTest.java
Outdated
Show resolved
Hide resolved
.../org/eclipse/hono/deviceconnection/infinispan/client/CacheBasedDeviceConnectionInfoTest.java
Outdated
Show resolved
Hide resolved
client/src/test/java/org/eclipse/hono/client/impl/DeviceConnectionClientImplTest.java
Outdated
Show resolved
Hide resolved
client/src/test/java/org/eclipse/hono/client/impl/DeviceConnectionClientImplTest.java
Outdated
Show resolved
Hide resolved
client/src/test/java/org/eclipse/hono/client/impl/DeviceConnectionClientImplTest.java
Outdated
Show resolved
Hide resolved
client/src/test/java/org/eclipse/hono/client/impl/DeviceConnectionClientImplTest.java
Outdated
Show resolved
Hide resolved
client/src/test/java/org/eclipse/hono/client/impl/DeviceConnectionClientImplTest.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/org/eclipse/hono/tests/registry/DeviceConnectionApiTests.java
Show resolved
Hide resolved
This reverts eclipse-hono#1926 and makes the method behave according to the API spec again, returning a failed Future if the entry wasn't removed. Signed-off-by: Carsten Lohmann <[email protected]>
calohmn
force-pushed
the
PR/devcon_client_removeadapterinstance_return_void
branch
from
f2cae32 to
59725aa
Compare
calohmn
deleted the
PR/devcon_client_removeadapterinstance_return_void
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #1926 and makes the method behave according to the API spec again, returning a failed Future if the entry wasn't removed.
Motivated by discussion here: #2251 (comment).