[#1858] Use ttd as command consumer lifespan #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calohmn
added
C&C
ctron
suggested changes
Apr 22, 2020
client/src/main/java/org/eclipse/hono/client/ProtocolAdapterCommandConsumerFactory.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/eclipse/hono/client/ProtocolAdapterCommandConsumerFactory.java
Outdated
Show resolved
Hide resolved
...qp-vertx/src/main/java/org/eclipse/hono/adapter/amqp/impl/VertxBasedAmqpProtocolAdapter.java
Outdated
Show resolved
Hide resolved
calohmn
force-pushed
the
PR/use_ttd_for_createcmdconsumer
branch
from
27fca73 to
036decd
Compare
Also change the type of the lifespan parameter from int to Duration in the methods of the DeviceConnectionInfo, DeviceConnectionClient and DeviceConnectionService interfaces. Signed-off-by: Carsten Lohmann <[email protected]>
calohmn
force-pushed
the
PR/use_ttd_for_createcmdconsumer
branch
from
036decd to
cb31782
Compare
ctron
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #1858.