Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#780] Extract methods out of HonoClient into new HonoApplicationClient #1085

Closed

Conversation

calohmn
Copy link
Contributor

@calohmn calohmn commented Mar 13, 2019

This is the first part of the solution for #780.

(Javadoc for the new classes adopted from the base classes for now; will be adapted once split of HonoClient is complete.)

@sophokles73
Copy link
Contributor

@calohmn Thanks for taking the initiative on this one. I was not aware of your intention to work on it so I started to do so myself several days ago. I was under the impression that you are deep into #930.
I will take a look at this PR and see how it relates to the work I have been doing so far. I suggest that you focus on #930 for the time being until I prepare a PR myself, ok?

@calohmn
Copy link
Contributor Author

calohmn commented Mar 14, 2019

ok, closing this.

@calohmn calohmn closed this Mar 14, 2019
@calohmn calohmn deleted the PR/honoapplicationclient branch April 30, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants