Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Reuse 'releaseVersion' property from eclipse-platform-parent #686

Merged

Conversation

HannesWell
Copy link
Member

Don't redefine the releaseVersion from the eclipse-platform-parent/pom.xml with a slightly different value.

This reduces the number of required changes in the preparation of new release-cycles and unblocks
eclipse-platform/eclipse.platform.releng.aggregator#2799

Copy link

github-actions bot commented Feb 1, 2025

Test Results

  375 files  ±0    375 suites  ±0   42m 6s ⏱️ - 1m 5s
1 905 tests ±0  1 902 ✅ ±0  3 💤 ±0  0 ❌ ±0 
6 715 runs  ±0  6 706 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 3a50265. ± Comparison against base commit ec15d03.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member

laeubi commented Feb 1, 2025

The variable in the pom is for CI friendly versions to work correctly here (I'm a bit surprised that inherit the value from the parent works) and it is only allowed to contain a constant string (at least for Maven 3.9).

I'm a bit confused why the build succeeds anyways, but we should simply add the constant to the qualifier part <qualifier>.0-SNAPSHOT</qualifier> or use one of the other CI variables for example <revision>.0</revision> so the version becomes <version>${releaseVersion}${revision}${qualifier}</version>

Don't redefine the 'releaseVersion' from the
eclipse-platform-parent/pom.xml with a slightly different value.

This reduces the number of required changes in the preparation of new
release-cycles and unblocks
eclipse-platform/eclipse.platform.releng.aggregator#2799
@HannesWell HannesWell force-pushed the reuse-parent-releaseVersion branch from 22ba2ea to 3a50265 Compare February 1, 2025 11:48
@HannesWell
Copy link
Member Author

The variable in the pom is for CI friendly versions to work correctly here (I'm a bit surprised that inherit the value from the parent works) and it is only allowed to contain a constant string (at least for Maven 3.9).

The build here is running with maven 3.9.9. I assumed that it doesn't matter where the variable is defined, but I have also not looked into that topic deeply. I'm just happy that it works :)

but we should simply add the constant to the qualifier part <qualifier>.0-SNAPSHOT</qualifier>

Sure that makes the change even simpler. Applied it.

@HannesWell HannesWell requested a review from laeubi February 1, 2025 11:52
@HannesWell
Copy link
Member Author

Btw. I checked the logs and the resolved version is as expected:

[INFO] -----------------< org.eclipse.platform:rt.equinox.p2 >-----------------
[INFO] Building rt.equinox.p2 4.35.0-SNAPSHOT                            [1/52]

@HannesWell HannesWell merged commit 22405a7 into eclipse-equinox:master Feb 1, 2025
12 checks passed
@HannesWell HannesWell deleted the reuse-parent-releaseVersion branch February 1, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants