Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for bundles/org.eclipse.equinox.p2.updatesite #683

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Clean Code for bundles/org.eclipse.equinox.p2.updatesite #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ....p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/RemoteUpdateSiteAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
* IUs generated for the bundles are "partial" as the bundles themselves are not downloaded.
*/
public class RemoteUpdateSiteAction implements IPublisherAction {
private UpdateSite updateSite;
private final UpdateSite updateSite;
private final String categoryQualifier;

/**
Expand Down
10 changes: 5 additions & 5 deletions ...ipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/UpdateSite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ public class UpdateSite {
private static final int RETRY_COUNT = 2;
private static final String DOT_XML = ".xml"; //$NON-NLS-1$
private static final String SITE = "site"; //$NON-NLS-1$
private String checksum;
private URI location;
private URI rootLocation;
private SiteModel site;
private final String checksum;
private final URI location;
private final URI rootLocation;
private final SiteModel site;

/*
* Some variables for caching.
Expand All @@ -61,7 +61,7 @@ public class UpdateSite {
private Map<String, Feature> featureCache = new HashMap<>();
// map of String (bundleID_featureVersion) to BundleDescriptr
private Map<String, BundleDescription> bundleCache = new HashMap<>();
private Transport transport;
private final Transport transport;

/*
* Return a URI based on the given URI, which points to a site.xml file.
Expand Down
4 changes: 2 additions & 2 deletions ...src/org/eclipse/equinox/internal/p2/updatesite/artifact/UpdateSiteArtifactRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ public class UpdateSiteArtifactRepository implements IArtifactRepository {
public static final String TYPE = "org.eclipse.equinox.p2.updatesite.artifactRepository"; //$NON-NLS-1$
public static final String VERSION = Integer.toString(1);

private URI location;
private IArtifactRepository delegate;
private final URI location;
private final IArtifactRepository delegate;

public UpdateSiteArtifactRepository(URI location, IArtifactRepository repository) {
this.location = location;
Expand Down
4 changes: 2 additions & 2 deletions ...src/org/eclipse/equinox/internal/p2/updatesite/metadata/UpdateSiteMetadataRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ public class UpdateSiteMetadataRepository implements IMetadataRepository {
public static final String TYPE = "org.eclipse.equinox.p2.updatesite.metadataRepository"; //$NON-NLS-1$
public static final String VERSION = Integer.toString(1);

private URI location;
private IMetadataRepository delegate;
private final URI location;
private final IMetadataRepository delegate;

public UpdateSiteMetadataRepository(URI location, IMetadataRepository repository) {
this.location = location;
Expand Down
Loading