Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to all of ECF's ssl bundles and features #591

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

merks
Copy link
Contributor

@merks merks commented Jan 5, 2025

@merks
Copy link
Contributor Author

merks commented Jan 5, 2025

BTW, org.eclipse.ecf.provider.filetransfer.httpclient.ssl was removed from all products, but that hasn't existed for a very long time:

image

That makes me wonder about how meaningful/useful these products are.

@akurtakov
Copy link
Member

@merks I have wondered the same for years (when doing some similar changes to them like you) and strongly believe they are useless as they are not hooked in the maven build and probably non startable for years for what you pointed and other changes.

@merks
Copy link
Contributor Author

merks commented Jan 5, 2025

@akurtakov

We could try to delete the products folder, but that begs the next question about the examples which are probably only there for the products and hence pointless without the products.

image

@merks
Copy link
Contributor Author

merks commented Jan 5, 2025

I think the example bundles can all go too:

image

They're mentioned as friends and in some *.launch configurations.

And there appears to be come crappy, old documentation, but that's probably not the only crappy old documentation.

Copy link

github-actions bot commented Jan 5, 2025

Test Results

  375 files  +  250    375 suites  +250   41m 29s ⏱️ + 27m 11s
1 904 tests +    2  1 901 ✅ +    2  3 💤 ±0  0 ❌ ±0 
6 712 runs  +4 478  6 703 ✅ +4 472  9 💤 +6  0 ❌ ±0 

Results for commit ae209b3. ± Comparison against base commit 0d8fa84.

@merks
Copy link
Contributor Author

merks commented Jan 5, 2025

The failure looks like an unrelated glitch and the same tests passed for all the GitHub actions:

image

@merks merks merged commit 00aa69e into eclipse-equinox:master Jan 5, 2025
11 of 12 checks passed
@merks merks deleted the pr-ecf-ssl branch January 5, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants