Perform clean code of bundles/org.eclipse.equinox.p2.operations

eclipse-equinox · Jan 29, 2025 · 9c4870d · 9c4870d
1 parent f62c027
commit 9c4870d
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 12 deletions.
diff --git a/....p2.operations/src/org/eclipse/equinox/internal/p2/operations/LoadFailureAccumulator.java b/....p2.operations/src/org/eclipse/equinox/internal/p2/operations/LoadFailureAccumulator.java
@@ -28,9 +28,9 @@
  */
 public final class LoadFailureAccumulator {
 
-	private RepositoryTracker repositoryTracker;
+	private final RepositoryTracker repositoryTracker;
 	private int loadFailuresNotCausedByBadRepoLocation;
-	private List<LoadFailure> loadFailuresCausedByBadRepoLocation;
+	private final List<LoadFailure> loadFailuresCausedByBadRepoLocation;
 
 	public LoadFailureAccumulator(RepositoryTracker repositoryTracker) {
 		this.repositoryTracker = repositoryTracker;

diff --git a/...e.equinox.p2.operations/src/org/eclipse/equinox/internal/p2/operations/RequestFlexer.java b/...e.equinox.p2.operations/src/org/eclipse/equinox/internal/p2/operations/RequestFlexer.java
@@ -40,7 +40,7 @@ public class RequestFlexer {
 	private boolean allowPartialInstall = false;
 
 	private boolean ensureProductPresence = true;
-	private boolean honorSharedSettings = true;
+	private final boolean honorSharedSettings = true;
 
 	private ProvisioningContext provisioningContext;
 

diff --git a/....eclipse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/ProvisioningJob.java b/....eclipse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/ProvisioningJob.java
@@ -132,7 +132,7 @@ public void worked(int work) {
 	 */
 	public static final int RESTART_ONLY = 3;
 
-	private ProvisioningSession session;
+	private final ProvisioningSession session;
 	private IProgressMonitor additionalMonitor;
 
 	/**

diff --git a/...ipse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/ProvisioningSession.java b/...ipse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/ProvisioningSession.java
@@ -44,7 +44,7 @@
  * @noextend This class is not intended to be subclassed by clients.
  */
 public class ProvisioningSession {
-	private IProvisioningAgent agent;
+	private final IProvisioningAgent agent;
 
 	Set<Job> scheduledJobs = Collections.synchronizedSet(new HashSet<>());
 

diff --git a/...pse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/RemediationOperation.java b/...pse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/RemediationOperation.java
@@ -44,7 +44,7 @@ public class RemediationOperation extends ProfileChangeOperation {
 	private Remedy bestSolutionChangingTheRequest;
 	private Remedy bestSolutionChangingWhatIsInstalled;
 	private Remedy currentRemedy;
-	private RemedyConfig[] remedyConfigs;
+	private final RemedyConfig[] remedyConfigs;
 
 	public RemedyConfig[] getRemedyConfigs() {
 		return remedyConfigs;
@@ -59,7 +59,7 @@ public void setCurrentRemedy(Remedy currentRemedy) {
 		request = currentRemedy == null ? null : currentRemedy.getRequest();
 	}
 
-	private IProfileChangeRequest originalRequest;
+	private final IProfileChangeRequest originalRequest;
 
 	public RemediationOperation(ProvisioningSession session, IProfileChangeRequest iProfileChangeRequest) {
 		this(session, iProfileChangeRequest, RemedyConfig.getAllRemedyConfigs());

diff --git a/bundles/org.eclipse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/Remedy.java b/bundles/org.eclipse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/Remedy.java
@@ -34,8 +34,8 @@ public class Remedy {
 	private ProfileChangeRequest request;
 	private int beingInstalledRelaxedWeight;
 	private int installationRelaxedWeight;
-	private IProfileChangeRequest originalRequest;
-	private List<RemedyIUDetail> iusDetails;
+	private final IProfileChangeRequest originalRequest;
+	private final List<RemedyIUDetail> iusDetails;
 
 	public List<RemedyIUDetail> getIusDetails() {
 		return iusDetails;

diff --git a/...g.eclipse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/RemedyIUDetail.java b/...g.eclipse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/RemedyIUDetail.java
@@ -37,7 +37,7 @@ public class RemedyIUDetail {
 	private Version installedVersion;
 	private Version requestedVersion;
 	private Version beingInstalledVersion;
-	private IInstallableUnit iu;
+	private final IInstallableUnit iu;
 
 	public RemedyIUDetail(IInstallableUnit iu) {
 		this.iu = iu;

diff --git a/...lipse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/UninstallOperation.java b/...lipse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/UninstallOperation.java
@@ -44,7 +44,7 @@
  */
 public class UninstallOperation extends ProfileChangeOperation {
 
-	private Collection<IInstallableUnit> toUninstall;
+	private final Collection<IInstallableUnit> toUninstall;
 
 	/**
 	 * Create an uninstall operation on the specified provisioning session that uninstalls

diff --git a/....eclipse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/UpdateOperation.java b/....eclipse.equinox.p2.operations/src/org/eclipse/equinox/p2/operations/UpdateOperation.java
@@ -70,7 +70,7 @@ public class UpdateOperation extends ProfileChangeOperation {
 	public static final int STATUS_NOTHING_TO_UPDATE = IStatusCodes.NOTHING_TO_UPDATE;
 
 	private Collection<IInstallableUnit> iusToUpdate;
-	private HashMap<IInstallableUnit, List<Update>> possibleUpdatesByIU = new HashMap<>();
+	private final HashMap<IInstallableUnit, List<Update>> possibleUpdatesByIU = new HashMap<>();
 	private List<Update> defaultUpdates;
 
 	/**