Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added jdk.net to the JavaSE-1.8.profile #555

Closed
wants to merge 1 commit into from

Conversation

axeluhl
Copy link

@axeluhl axeluhl commented Mar 10, 2024

Java 8 has jdk.net as a package. However, it is missing from the Java 8 profile of the org.eclipse.osgi system bundle. This, in turn, causes other bundles that import the jdk.net package to fail resolve properly under Java 8. Shouldn't jdk.net therefore be declared in the profile?

See also https://docs.oracle.com/javase/8/docs/jre/api/net/socketoptions/spec/jdk/net/package-summary.html

Copy link

Test Results

   28 files  ±0     28 suites  ±0   11m 10s ⏱️ -28s
2 170 tests ±0  2 124 ✅ ±0  46 💤 ±0  0 ❌ ±0 
2 242 runs  ±0  2 196 ✅ ±0  46 💤 ±0  0 ❌ ±0 

Results for commit e85ea6f. ± Comparison against base commit f9b6e09.

@mickaelistria
Copy link
Contributor

Isn't jdk.net mostly an internal JVM package? ie there are most likely a lot of other types in it that aren't API and shouldn't be made available by default.
Note that as a workaround, you can create a system bundle fragment that exports java.net so it becomes visible to consumers; or you can set the osgi.java.profile system property to point to a custom profile.

@laeubi
Copy link
Member

laeubi commented Mar 11, 2024

org.osgi.framework.system.packages.extra is the standard way to expose any additional (maybe jvm specific) packages:
https://docs.osgi.org/specification/osgi.core/8.0.0/framework.lifecycle.html#framework.lifecycle.launchingproperties

@axeluhl axeluhl closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants