[memory] intern ConfigurationElement.propertiesAndValue #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to get rid of this 4MB overhead: |
laeubi
reviewed
Feb 21, 2024
| @@ -299,7 +299,7 @@ private String[] readPropertiesAndValue(DataInputStream inputStream) throws IOEx | |||
| return RegistryObjectManager.EMPTY_STRING_ARRAY; | |||
| String[] properties = new String[numberOfProperties]; | |||
| for (int i = 0; i < numberOfProperties; i++) { | |||
| properties[i] = readStringOrNull(inputStream); | |||
| properties[i] = readStringOrNull(inputStream).intern(); | |||
There was a problem hiding this comment.
The method name suggest it could be null, maybe better intern in the method itself?
There was a problem hiding this comment.
thanks for the hint - in which method?
There was a problem hiding this comment.
thanks for the hint - in which method?
readStringOrNull
There was a problem hiding this comment.
I'm not sure if there are two such methods:
There was a problem hiding this comment.
I'm not sure if there are two such methods:
Well the one that this TabelReader calls then...
jukzi
force-pushed
the
intern_ConfigurationElement.propertiesAndValue
branch
from
f1d6c6e to
dc03374
Compare
jukzi
force-pushed
the
intern_ConfigurationElement.propertiesAndValue
branch
from
dc03374 to
98fd256
Compare
o.e.core.internal.registry.ConfigurationElement.propertiesAndValue is likely to contain duplicate Strings like "true"
jukzi
force-pushed
the
intern_ConfigurationElement.propertiesAndValue
branch
from
98fd256 to
52bce90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o.e.core.internal.registry.ConfigurationElement.propertiesAndValue is likely to contain duplicate Strings like "true"