Remove abstract OSGiTest class and dependency to CoreTest #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
remove-coretest_osgitest
branch
from
62743a7 to
f2db26c
Compare
akurtakov
force-pushed
the
remove-coretest_osgitest
branch
from
f2db26c to
1fa6887
Compare
|
@HeikoKlare You should be able to continue here as all other PRs are merged in |
HeikoKlare
force-pushed
the
remove-coretest_osgitest
branch
from
1fa6887 to
824884d
Compare
|
Thanks, @akurtakov! I've update this PR accordingly. |
This removes all dependencies to the to-be-removed JUnit 3-specific CoreTest class. To this end, the OSGiTest class, which only contains utility methods, is removed and the remaining utility fields and methods moved to the existing OSGiTestActivator class.
akurtakov
force-pushed
the
remove-coretest_osgitest
branch
from
824884d to
a5fe976
Compare
akurtakov
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all dependencies to the to-be-removed JUnit 3-specific CoreTest class. To this end, the OSGiTest class, which only contains utility methods, is removed and the remaining utility fields and methods moved to the existing OSGiTestActivator class.