Fix always existing bug in model order port sorting. #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previous layer. Updated WEST side handling to fix this and fixed typo as well and makes port model order non constraining for input ports.
|
This shows the model I wanted to fix and the one I broke. Apparently my bug only works for models were the edges originate from the same node. |
|
This does not seem to be everything. Somehow, this is different. |
I could solve this maybe by doing the inversePortProcessor after this.
|
eclipse-elk/elk-models#22 adds the correctness test as an example model. Maybe check, whether I should add more concrete tests for all corner cases here. |
Eddykasp
requested changes
Aug 20, 2024
|
Fixes #1065 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the order of incoming ports matches the order given by the previous layer.
Updated WEST side handling to fix the main issue. Moreover, there was a p1/p2 typo as well.
This also makes port model order non-constraining for input ports same as the edge model order.
If one wants to constrain the port order one should use portConstraints.