Do not close passed-in Writer (#604) #662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greek1979
force-pushed
the
keep-writers-open
branch
2 times, most recently
from
860bd27 to
5688945
Compare
greek1979
force-pushed
the
keep-writers-open
branch
from
5688945 to
5a5a975
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not close the
Writerresources that has been supplied to theJsonBindingmethods by the caller. Let the latter manage the lifecycle of the output writer. This preventsjava.io.IOException: Stream closederrors with Spring Native and Spring Boot when generating a JSON response from an HTTP method, for example, as Spring assumes the JSON-B implementation serializes the passed in POJO into JSON, writes it to a suppliedWriterbut does not close it yet. Flushing the output is perfectly fine and is acceptable, of course.See #604 for details of the regression introduced in Yasson 3.0.3 and #389 for the description of the original bug.