Fix mojarra 5 initialization with empty dd files #5537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guarantee that CDI is present at that moment, so logic has been moved into ConfigureListener
caused `java.lang.NullPointerException: Cannot invoke "jakarta.faces.event.PhaseEvent.getPhaseId()" because "event" is null` when an empty project is deployed which has no phase listeners
mnriem
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two issues discovered while finally getting Faces 5.0 / Mojarra 5.0 TCK to work as per jakartaee/faces#1988
FacesConfig.ContextParamcannot be checked inFacesInitializerbecause there is no guarantee that CDI is present at that moment (due toServletContainerInitializerordering being undefined, see also Add capability of ordering ServletContainerInitializer invocations jakartaee/servlet#548), so logic has been moved intoConfigureListenerjava.lang.NullPointerException: Cannot invoke "jakarta.faces.event.PhaseEvent.getPhaseId()" because "event" is nullwhen an empty project is deployed which has no phase listeners