ui:repeat clarification on attributes, such as offset and size #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved spec wrt ui:repeat attributes
Fixed impl as per improved spec on ui:repeat attributes
|
LGTM. If it is targeted to only 5.0 is it maybe time to make UIRepeat go to the same package as the rest of the UI classes? |
mnriem
approved these changes
Oct 8, 2023
definition always ui
|
|
+1 |
|
+1 for everything 😃 |
|
Associated TCK jakartaee/faces#1852 |
|
@BalusC Is this waiting on a review? Looks like the jakarta-faces side was done? |
|
I actually waited for a working TCK. But yeah, I'll just merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jakartaee/faces#1713
cc @tandraschko