Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: Removed obselete warning about non-standard soap 1.2 #700 #703

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Jan 13, 2025

We were discussing this @lukasj and me by zoom and he asked me to revert this because the warning is currently correct since the xml-ws spec considers SOAP 1.2 as to be supported in the future (see https://jakarta.ee/specifications/xml-web-services/4.0/jakarta-xml-ws-spec-4.0#goals ) and is currently optional (search through the spec for "SOAP 1.2" to learn more).

acceptable form of this change can be:

  • full update through the XML-WS spec as well as the implementation and addition of new TCKs

or

  • addition of an option to suppress warnings like this, instead of forcing it.

PR was: #700

Signed-off-by: Jorge Bescos Gascon <[email protected]>
@m0mus m0mus merged commit f16a1ae into eclipse-ee4j:master Jan 13, 2025
3 checks passed
@bdrx312
Copy link
Contributor

bdrx312 commented Jan 16, 2025

https://jakarta.ee/specifications/xml-web-services/4.0/jakarta-xml-ws-spec-4.0#extensibility sounds like extensions can be used be are not supported in a standard way. This sounds to me like enabling extensions with wsimport -extension at all is not standard which lines up with (https://docs.oracle.com/javase/8/docs/technotes/tools/unix/[wsimport](https://docs.oracle.com/javase/8/docs/technotes/tools/unix/wsimport.html).html)

-extension
Allows vendor extensions. Use of extensions can result in applications that are not portable or that do not work with other implementations.

which means that specifying -extension in of itself should be enough to not print warnings every time an extension is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants