Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sql): create SqlDidResourceStore #191

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Creates an InMemoryDidResourceStore SqlDidResourceStore plus accompanying glue code and tests.

Why it does that

IATP, persistence for DID resources

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #187

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added enhancement New feature or request dcp labels Dec 8, 2023
@paullatzelsperger paullatzelsperger force-pushed the feat/187_create_did_resourcestore branch 4 times, most recently from f0ebbe3 to 56c89cd Compare December 8, 2023 12:55
@paullatzelsperger paullatzelsperger marked this pull request as ready for review December 8, 2023 14:03
@paullatzelsperger paullatzelsperger force-pushed the feat/187_create_did_resourcestore branch from 56c89cd to 696d2ee Compare December 8, 2023 14:06
Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK once the comments are resolved.

@paullatzelsperger paullatzelsperger force-pushed the feat/187_create_did_resourcestore branch from 696d2ee to 65ed566 Compare December 8, 2023 15:00
@paullatzelsperger paullatzelsperger force-pushed the feat/187_create_did_resourcestore branch from 65ed566 to 0688a4e Compare December 10, 2023 09:53
@paullatzelsperger paullatzelsperger merged commit eb7b540 into eclipse-edc:main Dec 10, 2023
10 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/187_create_did_resourcestore branch December 10, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dcp enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IATP: Create implementation for the DIDResourceStore
2 participants