-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sql): create SqlDidResourceStore #191
Merged
paullatzelsperger
merged 2 commits into
eclipse-edc:main
from
paullatzelsperger:feat/187_create_did_resourcestore
Dec 10, 2023
Merged
feat(sql): create SqlDidResourceStore #191
paullatzelsperger
merged 2 commits into
eclipse-edc:main
from
paullatzelsperger:feat/187_create_did_resourcestore
Dec 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
feat/187_create_did_resourcestore
branch
4 times, most recently
from
December 8, 2023 12:55
f0ebbe3
to
56c89cd
Compare
paullatzelsperger
force-pushed
the
feat/187_create_did_resourcestore
branch
from
December 8, 2023 14:06
56c89cd
to
696d2ee
Compare
jimmarino
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK once the comments are resolved.
...hub-did/src/main/java/org/eclipse/edc/identityhub/did/defaults/InMemoryDidResourceStore.java
Show resolved
Hide resolved
...hub-did/src/main/java/org/eclipse/edc/identityhub/did/defaults/InMemoryDidResourceStore.java
Outdated
Show resolved
Hide resolved
...re-sql/src/main/java/org/eclipse/edc/identityhub/did/store/sql/BaseSqlDialectStatements.java
Outdated
Show resolved
Hide resolved
...d-store-sql/src/main/resources/META-INF/services/org.eclipse.edc.spi.system.ServiceExtension
Outdated
Show resolved
Hide resolved
...ore-sql/src/test/java/org/eclipse/edc/identityhub/did/store/sql/SqlDidResourceStoreTest.java
Outdated
Show resolved
Hide resolved
...-did/src/main/java/org/eclipse/edc/identityhub/did/defaults/DidDefaultServicesExtension.java
Outdated
Show resolved
Hide resolved
...did/src/test/java/org/eclipse/edc/identityhub/did/defaults/InMemoryDidResourceStoreTest.java
Outdated
Show resolved
Hide resolved
...c/testFixtures/java/org/eclipse/edc/identityhub/did/store/test/DidResourceStoreTestBase.java
Outdated
Show resolved
Hide resolved
paullatzelsperger
force-pushed
the
feat/187_create_did_resourcestore
branch
from
December 8, 2023 15:00
696d2ee
to
65ed566
Compare
paullatzelsperger
force-pushed
the
feat/187_create_did_resourcestore
branch
from
December 10, 2023 09:53
65ed566
to
0688a4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Creates an
InMemoryDidResourceStore
SqlDidResourceStore
plus accompanying glue code and tests.Why it does that
IATP, persistence for DID resources
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #187
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.