Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] introduced default timeout parameter for client service method calls #1984

Merged
merged 2 commits into from
Jan 31, 2025
Merged

[core] introduced default timeout parameter for client service method calls #1984

merged 2 commits into from
Jan 31, 2025

Conversation

rex-schilasky
Copy link
Contributor

Description

As the title says. This will simplify the client method call API function usage a remarkable.

@rex-schilasky rex-schilasky added the cherry-pick-to-NONE Don't cherry-pick these changes label Jan 31, 2025
KerstinKeller
KerstinKeller reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@KerstinKeller KerstinKeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about client_instance.h? We should have the same arguemnt ordering and default arguements there.

@rex-schilasky
Copy link
Contributor Author

What about client_instance.h? We should have the same arguemnt ordering and default arguements there.

Adapted as well.

@KerstinKeller KerstinKeller merged commit b7dc7ce into master Jan 31, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KerstinKeller KerstinKeller KerstinKeller left review comments

@hannemn hannemn hannemn approved these changes

Assignees
No one assigned
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rex-schilasky @KerstinKeller @hannemn