Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] client eventcallback as reference and cmakelists whitespace alignment #1980

Merged
merged 8 commits into from
Jan 30, 2025
Merged

[core] client eventcallback as reference and cmakelists whitespace alignment #1980

merged 8 commits into from
Jan 30, 2025

Conversation

rex-schilasky
Copy link
Contributor

@rex-schilasky rex-schilasky commented Jan 30, 2025 •
edited
Loading

Description

  • event_callback passed as reference (CServiceClient)
  • event_callback passed as reference (CServiceServer)
  • CMakeLists.txt whitespace alignment after massive renaming :-)
  • ecal/types/ecal_custom_data_types renamed to ecal/types/custom_data_types
  • doxygen fixes

@rex-schilasky rex-schilasky added the cherry-pick-to-NONE Don't cherry-pick these changes label Jan 30, 2025
@rex-schilasky rex-schilasky added this to the eCAL 6 milestone Jan 30, 2025
KerstinKeller
KerstinKeller reviewed Jan 30, 2025
View reviewed changes
ecal/core/CMakeLists.txt
@@ -538,6 +538,7 @@ set(ecal_header_cmn
include/ecal/service/client_instance.h
include/ecal/service/server.h
include/ecal/service/types.h
include/ecal/types/custom_data_types.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming custom_data_types.h is not really in line with the naming of all our other header files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know .. I just started to remove the ecal_ prefix for now.

@rex-schilasky rex-schilasky merged commit 8f23ace into master Jan 30, 2025
22 checks passed
@rex-schilasky rex-schilasky deleted the core/client-api-fix-and-cmakelists-cleanup branch January 30, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KerstinKeller KerstinKeller KerstinKeller approved these changes

Assignees
No one assigned
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Milestone
eCAL 6
Development

Successfully merging this pull request may close these issues.
2 participants
@rex-schilasky @KerstinKeller