Feature/variable renaming service

.clang-tidy

@@ -40,6 +40,7 @@ Checks: "-*,
   misc-*,
   -misc-non-private-member-variables-in-classes,
   -misc-no-recursion,
+  -misc-include-cleaner,
 
   modernize-*,
   -modernize-pass-by-value,
@@ -51,15 +52,18 @@ Checks: "-*,
   -modernize-avoid-bind,
 
   performance-*,
+  -performance-avoid-endl,
 
   readability-*,
   -readability-braces-around-statements,
+  -readability-else-after-return,
+  -readability-function-cognitive-complexity,
   -readability-identifier-length,
   -readability-magic-numbers,
   -readability-redundant-access-specifiers,
-  -readability-function-cognitive-complexity,
-  -readability-else-after-return,
   -readability-uppercase-literal-suffix,
+  -readability-use-anyofallof,
+  -readability-avoid-const-params-in-decls,
 "
 WarningsAsErrors: ''
 HeaderFilterRegex: '^((?!/thirdparty/|/_deps/).)*$'

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -118,7 +118,7 @@ body:
       Platform                 : x64
 
       ------------------------- CONFIGURATION --------------------------
-      Default INI              : C:\ProgramData\eCAL\ecal.ini
+      Default YAML             : C:\ProgramData\eCAL\ecal.yaml
 
       ------------------------- NETWORK --------------------------------
       Host name                : FRLBJRXW

.github/pull_request_template.md

@@ -4,10 +4,3 @@
 ### Related issues
 <!-- Type "Fixes #123" to automatically close that issue, when this PR is merged -->
 - 
-
-### Cherry-pick to
-<!-- Leave empty, if you don't know. For master-only changes use "none"
-- _none_
-- 5.11 (old stable)
-- 5.12 (current stable)
--->

.github/workflows/build-macos.yml

@@ -8,38 +8,27 @@ on:
 
 jobs:
   build-macos:
-    runs-on: macos-latest
+    runs-on: macos-13
 
     steps:
-    - name: Downgrade Python version
-      uses: actions/setup-python@v4
-      id: cp39
-      with:
-        python-version: '3.9'
+      # XProtect can cause random failures if it decides that the DMG we create
+      # during the packaging phase is malware.
+      # See https://github.com/actions/runner-images/issues/7522 and https://github.com/servo/servo/pull/30779
+    - name: Kill XProtectBehaviorService
+      run: |
+          echo Killing XProtect.; sudo pkill -9 XProtect >/dev/null || true;
+
+    - name: Install latest Python3 via brew
+      run: brew install python3 || brew link --overwrite [email protected]
 
-    - name: Install Qt
-      uses: jurplel/install-qt-action@v3
-      with:
-        setup-python: false
-        version: '5.15.2'
-        target: 'desktop'
+    - name: Install latest Qt5 via brew
+      run: brew install qt@5
 
     - name: Install Dependencies
-      run: brew install ninja doxygen graphviz protobuf [email protected] pkg-config
-
-    - name: Install Cap’n Proto
-      run: |
-        mkdir "${{ runner.workspace }}/capnp"
-        cd "${{ runner.workspace }}/capnp"
-        curl -O https://capnproto.org/capnproto-c++-0.9.0.tar.gz
-        tar zxf capnproto-c++-0.9.0.tar.gz
-        cd capnproto-c++-0.9.0
-        ./configure
-        make -j
-        sudo make install
+      run: brew install ninja doxygen graphviz protobuf [email protected] pkg-config capnp
 
     - name: Checkout
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         submodules:  'true'
         fetch-depth: 0
@@ -49,13 +38,14 @@ jobs:
 
     - name: Install Python requirements
       run: |
-        sudo pip3 install -r "$GITHUB_WORKSPACE/doc/requirements.txt"
+        sudo pip3 install -r "$GITHUB_WORKSPACE/doc/requirements.txt" --break-system-packages
 
     - name: CMake
       run: |
         mkdir "${{ runner.workspace }}/_build"
         cd "${{ runner.workspace }}/_build"
         cmake $GITHUB_WORKSPACE -G "Ninja" \
+        -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=cmake/submodule_dependencies.cmake \
         -DHAS_HDF5=ON \
         -DHAS_QT5=ON \
         -DHAS_CURL=ON \
@@ -68,9 +58,7 @@ jobs:
         -DBUILD_PY_BINDING=ON \
         -DBUILD_CSHARP_BINDING=OFF \
         -DBUILD_ECAL_TESTS=ON \
-        -DECAL_INCLUDE_PY_SAMPLES=OFF \
         -DECAL_INSTALL_SAMPLE_SOURCES=ON \
-        -DECAL_JOIN_MULTICAST_TWICE=OFF \
         -DECAL_NPCAP_SUPPORT=OFF \
         -DECAL_THIRDPARTY_BUILD_CMAKE_FUNCTIONS=ON \
         -DECAL_THIRDPARTY_BUILD_PROTOBUF=OFF \
@@ -83,23 +71,22 @@ jobs:
         -DECAL_THIRDPARTY_BUILD_RECYCLE=ON \
         -DECAL_THIRDPARTY_BUILD_TCP_PUBSUB=ON \
         -DECAL_THIRDPARTY_BUILD_QWT=ON \
-        -DECAL_THIRDPARTY_BUILD_YAML-CPP=ON \
         -DCMAKE_BUILD_TYPE=Release \
-        -DCMAKE_PREFIX_PATH=/usr/local/opt/[email protected] \
+        -DCMAKE_PREFIX_PATH="/usr/local/opt/[email protected];/usr/local/opt/qt@5" \
         -DCMAKE_CXX_STANDARD=17 \
         -DCMAKE_FIND_PACKAGE_PREFER_CONFIG=ON \
         -DPython_FIND_STRATEGY=LOCATION \
-        -DPython_FIND_REGISTRY=NEVER
-        sudo mkdir /etc/ecal
-        sudo cp "$GITHUB_WORKSPACE/ecal/core/cfg/ecal.ini" /etc/ecal
+        -DPython_FIND_REGISTRY=NEVER        
       shell: bash
 
     - name: Build Release
       run: cmake --build . --config Release
       working-directory: ${{ runner.workspace }}/_build
-
-    - name: Build Python Wheel
-      run: cmake --build . --target create_python_wheel --config Release
+
+    - name: Create config path and copy ecal.yaml
+      run: | 
+           sudo mkdir /etc/ecal
+           sudo cp "./ecal/core/cfg/gen/ecal.yaml" /etc/ecal
       working-directory: ${{ runner.workspace }}/_build
 
 #    - name: Build Documentation C
@@ -115,18 +102,17 @@ jobs:
 #      run: ctest -V
 #      working-directory: ${{ runner.workspace }}/_build
 
-    - name: Pack
-      run: cpack -G DragNDrop
-      working-directory: ${{ runner.workspace }}/_build
-
-    - name: Upload DMG
-      uses: actions/upload-artifact@v3
-      with:
-        name: macos-dmg
-        path: ${{ runner.workspace }}/_build/_deploy/*.dmg
-
-    - name: Upload Python Wheel
-      uses: actions/upload-artifact@v3
-      with:
-        name: macos-python-wheel
-        path: ${{ runner.workspace }}/_build/_deploy/*.whl
+#    Currently (2024-11-28) packing very often fails under macos
+#    - name: Pack
+#      uses: nick-fields/retry@v2
+#      with:
+#        max_attempts: 3
+#        retry_on: error
+#        timeout_minutes: 3
+#        command: cd ${{ runner.workspace }}/_build && cpack -G DragNDrop 
+
+#    - name: Upload DMG
+#      uses: actions/upload-artifact@v4
+#      with:
+#        name: macos-dmg
+#        path: ${{ runner.workspace }}/_build/_deploy/*.dmg