Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a CMake option for including the C language bindings.
I know this might be contentious, as I've seen sentiment that you have too many CMake options already (personally, I think its ok and I hope you never look at VTK :laughing).
It feels like the C bindings are considered important, which is why I kept it default-on and marked as advanced to indicate it probably shouldn't be touched.
The motivation is that, for example, I don't need it for my Go bindings so would like to be to exclude it from the container build (actually I see there's a
core_v5
target now which is a much larger unused resource for me...).If the marked-as-advanced option is still too much, I ask at least for an undocumented regular variable.
Related issues
Cherry-pick to