-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] rearrange service and pubsub headers into folders. #1934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
#include <ecal/ecal_time.h> | ||
#include <ecal/ecal_timer.h> | ||
#include <ecal/ecal_tlayer.h> | ||
#include <ecal/ecal_util.h> | ||
#include <ecal/config/configuration.h> | ||
#include <ecal/pubsub/publisher.h> | ||
#include <ecal/pubsub/subscriber.h> | ||
#include <ecal/service/client.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: duplicate include [readability-duplicate-include]
ecal/core/include/ecal/ecal.h:45:
- #include <ecal/pubsub/subscriber.h>
- #include <ecal/service/client.h>
+ #include <ecal/pubsub/subscriber.h>
#include <ecal/pubsub/publisher.h> | ||
#include <ecal/pubsub/subscriber.h> | ||
#include <ecal/service/client.h> | ||
#include <ecal/service/server.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include <ecal/ecal_publisher.h> | ||
#include <ecal/ecal_subscriber.h> | ||
#include <ecal/pubsub/publisher.h> | ||
#include <ecal/pubsub/subscriber.h> | ||
|
||
#include <gtest/gtest.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]
#include <gtest/gtest.h>
^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!!
New folder structure for headers: