Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] event handling cleanup #1921

Merged
merged 3 commits into from
Jan 20, 2025
Merged

[core] event handling cleanup #1921

merged 3 commits into from
Jan 20, 2025
+59 −148

Conversation

rex-schilasky
Copy link
Contributor

Description

  • Removed corrupted and update_connection events from eSubscriberEvent and ePublisherEvent enums.
  • Removed clock field from SPubEventCallbackData and SSubEventCallbackData structs.
  • Added FireDroppedEvent function to CSubscriberImpl.

@rex-schilasky
Removed corrupted and update_connection events from `eSubscriberE…
f849ef4 
…vent` and `ePublisherEvent` enums. Removed `clock` field from `SPubEventCallbackData` and `SSubEventCallbackData` structs. Added `FireDroppedEvent` function to `CSubscriberImpl` and updated dropped message handling.
@rex-schilasky rex-schilasky added the cherry-pick-to-NONE Don't cherry-pick these changes label Jan 20, 2025
@rex-schilasky rex-schilasky added this to the eCAL 6 milestone Jan 20, 2025
github-actions[bot]
github-actions bot reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

serialization/protobuf/samples/pubsub/person_events_snd/src/person_events_snd.cpp
default:
std::cout << "event : " << "unknown" << std::endl;
std::cout << "event : " << "unknown" << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change
std::cout << "event : " << "unknown" << std::endl;
std::cout << "event : " << "unknown" << '\n';

KerstinKeller
KerstinKeller approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@KerstinKeller KerstinKeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rex-schilasky
ecal_core_c test failed on my machine because of missing definition E…
98fb84c 
…CAL_OS_WINDOWS (compare process_name/unit_name failed core_test.cpp line 127)
@KerstinKeller
Copy link
Contributor

Strictly speaking, the header files from ecal core (like ecal_os.h) are no longer available, when using eCAL::core_c.
This was done on purpose, but maybe we missed something which we do want to make available to the user.
E.g. we could generate an ecal_defc.h or similar. This is in line with maybe being able to release the language bindings of eCAL separately to eCAL itself.
When we tackle the C API, we should have a close look at what functionality we need from core.

So back to this test: I am not sure if this tests links both core and core_c, or why the headers are available in the first place.

@KerstinKeller KerstinKeller merged commit 8a70566 into master Jan 20, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@KerstinKeller KerstinKeller KerstinKeller approved these changes

Assignees
No one assigned
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Milestone
eCAL 6
Development

Successfully merging this pull request may close these issues.
2 participants
@rex-schilasky @KerstinKeller