Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Disable mon plugin and rec addon sdks by default unless building apps #1920

Merged

Conversation

DownerCase
Copy link
Contributor

@DownerCase DownerCase commented Jan 20, 2025

Description

Disables building the monitor plugin and rec addon unless BUILD_APPS is on.

These options are not part of eCAL core and aren't needed in a minimal configuration.

An option is made for the rec_addon but not the monitor plugin because the monitor app requires it. I presume it is unlikely one would want to use a local build to make a plugin but not build the gui app itself.

Related issues

closes #380

Cherry-pick to

@DownerCase DownerCase changed the title Disable mon plugin and rec addon sdks by default unless building apps [cmake] Disable mon plugin and rec addon sdks by default unless building apps Jan 20, 2025
Copy link
Contributor

@KerstinKeller KerstinKeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both options do make a lot of sense.
This might allow to remove the paths in pyproj.toml also:

ecal/pyproject.toml

Lines 47 to 48 in 6c9a238

"/app/rec/rec_addon_core/", # TODO: Remove this directory
"/app/rec/rec_addon_dummy/", # TODO: Remove this directory

@KerstinKeller KerstinKeller added the cherry-pick-to-NONE Don't cherry-pick these changes label Jan 20, 2025
@DownerCase
Copy link
Contributor Author

This might allow to remove the paths in pyproj.toml also:

ecal/pyproject.toml

Lines 47 to 48 in 6c9a238

"/app/rec/rec_addon_core/", # TODO: Remove this directory
"/app/rec/rec_addon_dummy/", # TODO: Remove this directory

Absolutely! Will check if the app/apps folder can be sorted too.

@KerstinKeller
Copy link
Contributor

We had previously used the app names in eCAL core, and thus always needed that folder. This dependency is no longer there, so it's fine to have that only when we have BUILD_APPS activated.

@KerstinKeller KerstinKeller merged commit 3465472 into eclipse-ecal:master Jan 20, 2025
11 of 12 checks passed
@DownerCase DownerCase deleted the feature/conditional-app-addons branch January 20, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants