Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Resolve SHM topic resubscribing in less than the registration timeout period creating "zombie subscribers" #1916

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DownerCase
Copy link
Contributor

@DownerCase DownerCase commented Jan 17, 2025

Description

Will eventually track down and resolve an issue with subscribers connecting but not receiving data.

Current status: Test case refined, problem understood (see issue for details).

Related issues

Cherry-pick to

@DownerCase DownerCase changed the title WIP: Resolve topic resubscribing creating "zombie subscribers" WIP: Resolve SHM topic resubscribing creating "zombie subscribers" Jan 17, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

ecal/tests/cpp/pubsub_test/src/pubsub_test_shm.cpp Outdated Show resolved Hide resolved
@DownerCase DownerCase changed the title WIP: Resolve SHM topic resubscribing creating "zombie subscribers" WIP: Resolve SHM topic resubscribing in less than the registration timeout period creating "zombie subscribers" Jan 18, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@@ -149,3 +150,113 @@ TEST(core_cpp_pubsub, MultipleSendsSHM)
// finalize eCAL API
eCAL::Finalize();
}

TEST(core_cpp_pubsub, SubscriberFastReconnectionSHM) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: all parameters should be named in a function [readability-named-parameter]

Suggested change
TEST(core_cpp_pubsub, SubscriberFastReconnectionSHM) {
TEST(core_cpp_pubsub /*unused*/, SubscriberFastReconnectionSHM /*unused*/) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant