[core] Change type of id in callbacks for server / client from SServiceMethodId to SServiceId. #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceMethodId to SServiceId.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -94,7 +94,7 @@ namespace eCAL | |||
| Logging::Log(Logging::log_level_debug1, "v5::CServiceClientImpl: Creating service client with name: " + service_name_); | |||
|
|
|||
| // Define the event callback to pass to CServiceClient | |||
| v6::ClientEventCallbackT event_callback = [this](const Registration::SServiceMethodId& service_id_, const v6::SClientEventCallbackData& data_) | |||
| v6::ClientEventCallbackT event_callback = [this](const Registration::SServiceId& service_id_, const v6::SClientEventCallbackData& data_) | |||
There was a problem hiding this comment.
warning: variable 'event_callback' of type 'v6::ClientEventCallbackT' (aka 'function<void (const Registration::SServiceId &, const SClientEventCallbackData &)>') can be declared 'const' [misc-const-correctness]
Suggested change
| v6::ClientEventCallbackT event_callback = [this](const Registration::SServiceId& service_id_, const v6::SClientEventCallbackData& data_) | |
| v6::ClientEventCallbackT const event_callback = [this](const Registration::SServiceId& service_id_, const v6::SClientEventCallbackData& data_) |
| @@ -57,7 +57,7 @@ namespace eCAL | |||
| } | |||
|
|
|||
| // Define the event callback to pass to CServiceClient | |||
| v6::ServerEventCallbackT event_callback = [this](const Registration::SServiceMethodId& service_id_, const v6::SServerEventCallbackData& data_) | |||
| v6::ServerEventCallbackT event_callback = [this](const Registration::SServiceId& service_id_, const v6::SServerEventCallbackData& data_) | |||
There was a problem hiding this comment.
warning: variable 'event_callback' of type 'v6::ServerEventCallbackT' (aka 'function<void (const Registration::SServiceId &, const struct SServerEventCallbackData &)>') can be declared 'const' [misc-const-correctness]
Suggested change
| v6::ServerEventCallbackT event_callback = [this](const Registration::SServiceId& service_id_, const v6::SServerEventCallbackData& data_) | |
| v6::ServerEventCallbackT const event_callback = [this](const Registration::SServiceId& service_id_, const v6::SServerEventCallbackData& data_) |
rex-schilasky
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering events to see if a Server / Client has connected, the correct datatype to signal this is SServiceId.